Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support pathlib.Path instances for file-type input #169

Closed
huard opened this issue Mar 4, 2020 · 1 comment
Closed

Support pathlib.Path instances for file-type input #169

huard opened this issue Mar 4, 2020 · 1 comment

Comments

@huard
Copy link
Contributor

huard commented Mar 4, 2020

Description

Reference to input files should be able to accept pathlib.Path objects.

@huard
Copy link
Contributor Author

huard commented Mar 10, 2020

The issue occurs when the server is localhost, and we don't need to embed the resource. The path is passed to birdy,utils.fix_url

def fix_url(url):
    """If url is a local path, add a file:// scheme."""
    return urlparse(url, scheme='file').geturl()

which does not support Path objects.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant