ClinVar Protein HGVS not being returned correctly?

[kkrysiak]

We noticed pulling data for CIViC that the Protein HGVS is missing but ClinVar definitely has these available. At least I thought it used to be available.

https://myvariant.info/v1/variant/chr7:g.140453136A%3ET?fields=clinvar.hgvs

https://www.ncbi.nlm.nih.gov/clinvar/variation/13961/

[erikyao]

@kkrysiak, it's confirmed that there is a hidden bug in our ClinVar data parser. Will fix soon. Thank you for pointing it out!

[erikyao]

@newgene It's caused by the ill-timed break statement on clinvar_xml_parser.py#L156. Some attributes (not only proteins) will be discarded after the break statement is executed.

A simple fix is to delete this break, but to avoid such problems in the future, a little bit refactoring might be necessary.

[erikyao]

Fix merged to codebase; waiting for new data release.