diff --git a/.changeset/grumpy-tires-roll.md b/.changeset/grumpy-tires-roll.md new file mode 100644 index 000000000000..ec0056979c36 --- /dev/null +++ b/.changeset/grumpy-tires-roll.md @@ -0,0 +1,5 @@ +--- +"@biomejs/biome": patch +--- + +Updated rule source metadata for rules from `html-eslint`. diff --git a/crates/biome_cli/src/execute/migrate/eslint_any_rule_to_biome.rs b/crates/biome_cli/src/execute/migrate/eslint_any_rule_to_biome.rs index f28d33d95528..a22d6b048475 100644 --- a/crates/biome_cli/src/execute/migrate/eslint_any_rule_to_biome.rs +++ b/crates/biome_cli/src/execute/migrate/eslint_any_rule_to_biome.rs @@ -221,6 +221,14 @@ pub(crate) fn migrate_eslint_any_rule( .get_or_insert(Default::default()); rule.set_level(rule.level().max(rule_severity.into())); } + "@html-eslint/no-accesskey-attrs" => { + let group = rules.a11y.get_or_insert_with(Default::default); + let rule = group + .unwrap_group_as_mut() + .no_access_key + .get_or_insert(Default::default()); + rule.set_level(rule.level().max(rule_severity.into())); + } "@html-eslint/no-duplicate-attrs" => { if !options.include_nursery { results.add(eslint_name, eslint_to_biome::RuleMigrationResult::Nursery); @@ -233,6 +241,38 @@ pub(crate) fn migrate_eslint_any_rule( .get_or_insert(Default::default()); rule.set_level(rule.level().max(rule_severity.into())); } + "@html-eslint/no-positive-tabindex" => { + let group = rules.a11y.get_or_insert_with(Default::default); + let rule = group + .unwrap_group_as_mut() + .no_positive_tabindex + .get_or_insert(Default::default()); + rule.set_level(rule.level().max(rule_severity.into())); + } + "@html-eslint/require-button-type" => { + let group = rules.a11y.get_or_insert_with(Default::default); + let rule = group + .unwrap_group_as_mut() + .use_button_type + .get_or_insert(Default::default()); + rule.set_level(rule.level().max(rule_severity.into())); + } + "@html-eslint/require-img-alt" => { + let group = rules.a11y.get_or_insert_with(Default::default); + let rule = group + .unwrap_group_as_mut() + .use_alt_text + .get_or_insert(Default::default()); + rule.set_level(rule.level().max(rule_severity.into())); + } + "@html-eslint/require-lang" => { + let group = rules.a11y.get_or_insert_with(Default::default); + let rule = group + .unwrap_group_as_mut() + .use_html_lang + .get_or_insert(Default::default()); + rule.set_level(rule.level().max(rule_severity.into())); + } "@mysticatea/no-this-in-static" => { let group = rules.complexity.get_or_insert_with(Default::default); let rule = group diff --git a/crates/biome_cli/src/execute/migrate/unsupported_rules.rs b/crates/biome_cli/src/execute/migrate/unsupported_rules.rs index b3067262c09d..0723a90de9b3 100644 --- a/crates/biome_cli/src/execute/migrate/unsupported_rules.rs +++ b/crates/biome_cli/src/execute/migrate/unsupported_rules.rs @@ -328,6 +328,15 @@ pub const UNSUPPORTED_RULES: &[UnsupportedRule] = &[ UnsupportedRule(EslintVueJs("space-infix-ops"), FormatterCovers), UnsupportedRule(EslintVueJs("space-unary-ops"), FormatterCovers), UnsupportedRule(EslintVueJs("template-curly-spacing"), FormatterCovers), + UnsupportedRule(HtmlEslint("attrs-newline"), FormatterCovers), + UnsupportedRule(HtmlEslint("element-newline"), FormatterCovers), + UnsupportedRule(HtmlEslint("indent"), FormatterOption("indentWidth")), + UnsupportedRule(HtmlEslint("lowercase"), FormatterCovers), + UnsupportedRule(HtmlEslint("no-extra-spacing-attrs"), FormatterCovers), + UnsupportedRule(HtmlEslint("no-extra-spacing-text"), FormatterCovers), + UnsupportedRule(HtmlEslint("no-multiple-empty-lines"), FormatterCovers), + UnsupportedRule(HtmlEslint("no-trailing-spaces"), FormatterCovers), + UnsupportedRule(HtmlEslint("quotes"), FormatterCovers), ]; #[cfg(test)] diff --git a/crates/biome_html_analyze/src/lint/a11y/no_access_key.rs b/crates/biome_html_analyze/src/lint/a11y/no_access_key.rs index 982921983133..da70609b9035 100644 --- a/crates/biome_html_analyze/src/lint/a11y/no_access_key.rs +++ b/crates/biome_html_analyze/src/lint/a11y/no_access_key.rs @@ -42,7 +42,7 @@ declare_lint_rule! { version: "2.4.0", name: "noAccessKey", language: "html", - sources: &[RuleSource::EslintJsxA11y("no-access-key").same()], + sources: &[RuleSource::EslintJsxA11y("no-access-key").same(), RuleSource::HtmlEslint("no-accesskey-attrs").same()], recommended: true, severity: Severity::Error, fix_kind: FixKind::Unsafe, diff --git a/crates/biome_html_analyze/src/lint/a11y/no_positive_tabindex.rs b/crates/biome_html_analyze/src/lint/a11y/no_positive_tabindex.rs index 4746115a6129..5714eef416fe 100644 --- a/crates/biome_html_analyze/src/lint/a11y/no_positive_tabindex.rs +++ b/crates/biome_html_analyze/src/lint/a11y/no_positive_tabindex.rs @@ -42,7 +42,7 @@ declare_lint_rule! { version: "2.4.0", name: "noPositiveTabindex", language: "html", - sources: &[RuleSource::EslintJsxA11y("tabindex-no-positive").same()], + sources: &[RuleSource::EslintJsxA11y("tabindex-no-positive").same(), RuleSource::HtmlEslint("no-positive-tabindex").same()], recommended: true, severity: Severity::Error, fix_kind: FixKind::Unsafe, diff --git a/crates/biome_html_analyze/src/lint/a11y/use_alt_text.rs b/crates/biome_html_analyze/src/lint/a11y/use_alt_text.rs index 26ea4523ebe1..49e6f254c97f 100644 --- a/crates/biome_html_analyze/src/lint/a11y/use_alt_text.rs +++ b/crates/biome_html_analyze/src/lint/a11y/use_alt_text.rs @@ -85,7 +85,7 @@ declare_lint_rule! { version: "2.4.0", name: "useAltText", language: "html", - sources: &[RuleSource::EslintJsxA11y("alt-text").same()], + sources: &[RuleSource::EslintJsxA11y("alt-text").same(), RuleSource::HtmlEslint("require-img-alt").same()], recommended: true, severity: Severity::Error, } diff --git a/crates/biome_html_analyze/src/lint/a11y/use_button_type.rs b/crates/biome_html_analyze/src/lint/a11y/use_button_type.rs index fd52cfe00088..1721eb53c2ca 100644 --- a/crates/biome_html_analyze/src/lint/a11y/use_button_type.rs +++ b/crates/biome_html_analyze/src/lint/a11y/use_button_type.rs @@ -31,7 +31,7 @@ declare_lint_rule! { version: "2.4.0", name: "useButtonType", language: "html", - sources: &[RuleSource::EslintReact("button-has-type").same()], + sources: &[RuleSource::EslintReact("button-has-type").same(), RuleSource::HtmlEslint("require-button-type").same()], recommended: true, severity: Severity::Error, } diff --git a/crates/biome_html_analyze/src/lint/a11y/use_html_lang.rs b/crates/biome_html_analyze/src/lint/a11y/use_html_lang.rs index 97ac55903acf..79f9bf2dd690 100644 --- a/crates/biome_html_analyze/src/lint/a11y/use_html_lang.rs +++ b/crates/biome_html_analyze/src/lint/a11y/use_html_lang.rs @@ -38,7 +38,7 @@ declare_lint_rule! { version: "2.4.0", name: "useHtmlLang", language: "html", - sources: &[RuleSource::EslintJsxA11y("html-has-lang").same()], + sources: &[RuleSource::EslintJsxA11y("html-has-lang").same(), RuleSource::HtmlEslint("require-lang").same()], recommended: true, severity: Severity::Error, }