From 65374733f9baa11c908ad10206c840a6b939e35b Mon Sep 17 00:00:00 2001 From: Maikel Date: Fri, 21 Nov 2025 16:50:04 +0100 Subject: [PATCH 1/2] docs: missing rule references --- .../src/lint/correctness/use_jsx_key_in_iterable.rs | 2 +- crates/biome_js_analyze/src/lint/nursery/use_max_params.rs | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/crates/biome_js_analyze/src/lint/correctness/use_jsx_key_in_iterable.rs b/crates/biome_js_analyze/src/lint/correctness/use_jsx_key_in_iterable.rs index fa222a7bc9ce..db0f2b433242 100644 --- a/crates/biome_js_analyze/src/lint/correctness/use_jsx_key_in_iterable.rs +++ b/crates/biome_js_analyze/src/lint/correctness/use_jsx_key_in_iterable.rs @@ -62,7 +62,7 @@ declare_lint_rule! { version: "1.6.0", name: "useJsxKeyInIterable", language: "jsx", - sources: &[RuleSource::EslintReact("jsx-key").same()], + sources: &[RuleSource::EslintReact("jsx-key").same(), RuleSource::EslintQwik("jsx-key").same()], recommended: true, severity: Severity::Error, domains: &[RuleDomain::React, RuleDomain::Qwik], diff --git a/crates/biome_js_analyze/src/lint/nursery/use_max_params.rs b/crates/biome_js_analyze/src/lint/nursery/use_max_params.rs index f60090f7fd8c..79c86dafb286 100644 --- a/crates/biome_js_analyze/src/lint/nursery/use_max_params.rs +++ b/crates/biome_js_analyze/src/lint/nursery/use_max_params.rs @@ -74,7 +74,7 @@ declare_lint_rule! { version: "2.2.0", name: "useMaxParams", language: "js", - sources: &[RuleSource::Eslint("max-params").same(), RuleSource::Clippy("too_many_arguments").same()], + sources: &[RuleSource::Eslint("max-params").same(), RuleSource::Clippy("too_many_arguments").same(), RuleSource::EslintTypeScript("max-params").same()], severity: Severity::Warning, recommended: false, } From 74d6ad17cab42952527c14d8427552d4fceb61c1 Mon Sep 17 00:00:00 2001 From: "autofix-ci[bot]" <114827586+autofix-ci[bot]@users.noreply.github.com> Date: Fri, 21 Nov 2025 15:56:17 +0000 Subject: [PATCH 2/2] [autofix.ci] apply automated fixes --- .../migrate/eslint_any_rule_to_biome.rs | 20 +++++++++++++++++++ 1 file changed, 20 insertions(+) diff --git a/crates/biome_cli/src/execute/migrate/eslint_any_rule_to_biome.rs b/crates/biome_cli/src/execute/migrate/eslint_any_rule_to_biome.rs index 7adae101bb09..376b1c48c6c7 100644 --- a/crates/biome_cli/src/execute/migrate/eslint_any_rule_to_biome.rs +++ b/crates/biome_cli/src/execute/migrate/eslint_any_rule_to_biome.rs @@ -265,6 +265,18 @@ pub(crate) fn migrate_eslint_any_rule( .get_or_insert(Default::default()); rule.set_level(rule.level().max(rule_severity.into())); } + "@typescript-eslint/max-params" => { + if !options.include_nursery { + results.add(eslint_name, eslint_to_biome::RuleMigrationResult::Nursery); + return false; + } + let group = rules.nursery.get_or_insert_with(Default::default); + let rule = group + .unwrap_group_as_mut() + .use_max_params + .get_or_insert(Default::default()); + rule.set_level(rule.level().max(rule_severity.into())); + } "@typescript-eslint/naming-convention" => { if !options.include_inspired { results.add(eslint_name, eslint_to_biome::RuleMigrationResult::Inspired); @@ -2269,6 +2281,14 @@ pub(crate) fn migrate_eslint_any_rule( .get_or_insert(Default::default()); rule.set_level(rule.level().max(rule_severity.into())); } + "qwik/jsx-key" => { + let group = rules.correctness.get_or_insert_with(Default::default); + let rule = group + .unwrap_group_as_mut() + .use_jsx_key_in_iterable + .get_or_insert(Default::default()); + rule.set_level(rule.level().max(rule_severity.into())); + } "qwik/no-use-visible-task" => { let group = rules.correctness.get_or_insert_with(Default::default); let rule = group