From 673d5b2b8badf8c6548f70a94a5bafb3b58633d1 Mon Sep 17 00:00:00 2001 From: Jeetu Suthar Date: Sun, 24 Aug 2025 22:40:17 +0530 Subject: [PATCH 1/2] fix(noDuplicateObjectKeys): correct grammatical error in JSON diagnostic message Fixed missing 'is' in the diagnostic message for the noDuplicateObjectKeys rule when applied to JSON files. The message now correctly reads 'This is where a duplicated key was declared again.' instead of 'This where a duplicated key was declared again.' Fixes #7307 --- .changeset/fix-grammar-duplicate-object-keys.md | 0 .../snapshots/main_commands_check/check_json_files.snap | 2 +- .../snapshots/main_commands_lint/check_json_files.snap | 2 +- .../src/lint/suspicious/no_duplicate_object_keys.rs | 2 +- .../suspicious/noDuplicateObjectKeys/invalid.json.snap | 8 ++++---- 5 files changed, 7 insertions(+), 7 deletions(-) create mode 100644 .changeset/fix-grammar-duplicate-object-keys.md diff --git a/.changeset/fix-grammar-duplicate-object-keys.md b/.changeset/fix-grammar-duplicate-object-keys.md new file mode 100644 index 000000000000..e69de29bb2d1 diff --git a/crates/biome_cli/tests/snapshots/main_commands_check/check_json_files.snap b/crates/biome_cli/tests/snapshots/main_commands_check/check_json_files.snap index f2f95769f35f..b0b286c128a7 100644 --- a/crates/biome_cli/tests/snapshots/main_commands_check/check_json_files.snap +++ b/crates/biome_cli/tests/snapshots/main_commands_check/check_json_files.snap @@ -43,7 +43,7 @@ test.json:1:3 lint/suspicious/noDuplicateObjectKeys ━━━━━━━━━ > 1 │ { "foo": true, "foo": true } │ ^^^^^ - i This where a duplicated key was declared again. + i This is where a duplicated key was declared again. > 1 │ { "foo": true, "foo": true } │ ^^^^^ diff --git a/crates/biome_cli/tests/snapshots/main_commands_lint/check_json_files.snap b/crates/biome_cli/tests/snapshots/main_commands_lint/check_json_files.snap index 1f54438ead59..1ddced683f3c 100644 --- a/crates/biome_cli/tests/snapshots/main_commands_lint/check_json_files.snap +++ b/crates/biome_cli/tests/snapshots/main_commands_lint/check_json_files.snap @@ -43,7 +43,7 @@ test.json:1:3 lint/suspicious/noDuplicateObjectKeys ━━━━━━━━━ > 1 │ { "foo": true, "foo": true } │ ^^^^^ - i This where a duplicated key was declared again. + i This is where a duplicated key was declared again. > 1 │ { "foo": true, "foo": true } │ ^^^^^ diff --git a/crates/biome_json_analyze/src/lint/suspicious/no_duplicate_object_keys.rs b/crates/biome_json_analyze/src/lint/suspicious/no_duplicate_object_keys.rs index 0fa14074d901..2ed96c0e8c0a 100644 --- a/crates/biome_json_analyze/src/lint/suspicious/no_duplicate_object_keys.rs +++ b/crates/biome_json_analyze/src/lint/suspicious/no_duplicate_object_keys.rs @@ -83,7 +83,7 @@ impl Rule for NoDuplicateObjectKeys { diagnostic = diagnostic.detail( range, markup! { - "This where a duplicated key was declared again." + "This is where a duplicated key was declared again." }, ); } diff --git a/crates/biome_json_analyze/tests/specs/suspicious/noDuplicateObjectKeys/invalid.json.snap b/crates/biome_json_analyze/tests/specs/suspicious/noDuplicateObjectKeys/invalid.json.snap index 1dac09218bd3..0d13ebdc58f9 100644 --- a/crates/biome_json_analyze/tests/specs/suspicious/noDuplicateObjectKeys/invalid.json.snap +++ b/crates/biome_json_analyze/tests/specs/suspicious/noDuplicateObjectKeys/invalid.json.snap @@ -31,7 +31,7 @@ invalid.json:2:2 lint/suspicious/noDuplicateObjectKeys ━━━━━━━━ 3 │ "foo": "", 4 │ "foo": "", - i This where a duplicated key was declared again. + i This is where a duplicated key was declared again. 1 │ { 2 │ "foo": "", @@ -40,7 +40,7 @@ invalid.json:2:2 lint/suspicious/noDuplicateObjectKeys ━━━━━━━━ 4 │ "foo": "", 5 │ "foo": "", - i This where a duplicated key was declared again. + i This is where a duplicated key was declared again. 2 │ "foo": "", 3 │ "foo": "", @@ -49,7 +49,7 @@ invalid.json:2:2 lint/suspicious/noDuplicateObjectKeys ━━━━━━━━ 5 │ "foo": "", 6 │ "new": { - i This where a duplicated key was declared again. + i This is where a duplicated key was declared again. 3 │ "foo": "", 4 │ "foo": "", @@ -75,7 +75,7 @@ invalid.json:7:3 lint/suspicious/noDuplicateObjectKeys ━━━━━━━━ 8 │ "ipsum": "", 9 │ "lorem": "" - i This where a duplicated key was declared again. + i This is where a duplicated key was declared again. 7 │ "lorem": "", 8 │ "ipsum": "", From 84475960e2842bb483b7929a6ad5197983af5e40 Mon Sep 17 00:00:00 2001 From: Jeetu Suthar Date: Mon, 25 Aug 2025 00:51:29 +0530 Subject: [PATCH 2/2] remove changeset as suggested by reviewer --- .changeset/fix-grammar-duplicate-object-keys.md | 0 1 file changed, 0 insertions(+), 0 deletions(-) delete mode 100644 .changeset/fix-grammar-duplicate-object-keys.md diff --git a/.changeset/fix-grammar-duplicate-object-keys.md b/.changeset/fix-grammar-duplicate-object-keys.md deleted file mode 100644 index e69de29bb2d1..000000000000