Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

💅 noSvgWithoutTitle should skip if the element is visually hidden #910

Closed
1 task done
kevinwolfcr opened this issue Nov 27, 2023 · 1 comment · Fixed by #928
Closed
1 task done

💅 noSvgWithoutTitle should skip if the element is visually hidden #910

kevinwolfcr opened this issue Nov 27, 2023 · 1 comment · Fixed by #928
Assignees
Labels
A-Linter Area: linter good first issue Good for newcomers L-JavaScript Language: JavaScript and super languages

Comments

@kevinwolfcr
Copy link
Contributor

Environment information

CLI:
  Version:                      1.3.3
  Color support:                true

Platform:
  CPU Architecture:             aarch64
  OS:                           macos

Environment:
  BIOME_LOG_DIR:                unset
  NO_COLOR:                     unset
  TERM:                         "xterm-256color"
  JS_RUNTIME_VERSION:           "v18.15.0"
  JS_RUNTIME_NAME:              "node"
  NODE_PACKAGE_MANAGER:         "bun/1.0.14"

Biome Configuration:
  Status:                       Loaded successfully
  Formatter disabled:           false
  Linter disabled:              false
  Organize imports disabled:    false
  VCS disabled:                 false

Workspace:
  Open Documents:               0

Rule name

noSvgWithoutTitle

Playground link

https://biomejs.dev/playground/?lintRules=all&code=ZgB1AG4AYwB0AGkAbwBuACAARQB4AGEAbQBwAGwAZQAoACkAIAB7AAoAIAAgAHIAZQB0AHUAcgBuACAAKAAKACAAIAAgACAAPABzAHYAZwAKACAAIAAgACAAIAAgAGMAbABhAHMAcwBOAGEAbQBlAD0AIgBhAGIAcwBvAGwAdQB0AGUAIABpAG4AcwBlAHQALQAwACAALQB6AC0AMQAwACAAaAAtAGYAdQBsAGwAIAB3AC0AZgB1AGwAbAAgAHMAdAByAG8AawBlAC0AZwByAGEAeQAtADIAMAAwACAAWwBtAGEAcwBrAC0AaQBtAGEAZwBlADoAcgBhAGQAaQBhAGwALQBnAHIAYQBkAGkAZQBuAHQAKAAxADAAMAAlAF8AMQAwADAAJQBfAGEAdABfAHQAbwBwAF8AcgBpAGcAaAB0ACwAdwBoAGkAdABlACwAdAByAGEAbgBzAHAAYQByAGUAbgB0ACkAXQAiAAoAIAAgACAAIAAgACAAYQByAGkAYQAtAGgAaQBkAGQAZQBuAD0AIgB0AHIAdQBlACIACgAgACAAIAAgACAAIAA%2BAAoAIAAgACAAIAAgACAAIAAgADwAZABlAGYAcwA%2BAAoAIAAgACAAIAAgACAAIAAgACAAIAA8AHAAYQB0AHQAZQByAG4ACgAgACAAIAAgACAAIAAgACAAIAAgACAAIABpAGQAPQAiADAANwA4ADcAYQA3AGMANQAtADkANwA4AGMALQA0AGYANgA2AC0AOAAzAGMANwAtADEAMQBjADIAMQAzAGYAOQA5AGMAYgA3ACIACgAgACAAIAAgACAAIAAgACAAIAAgACAAIAB3AGkAZAB0AGgAPQB7ADIAMAAwAH0ACgAgACAAIAAgACAAIAAgACAAIAAgACAAIABoAGUAaQBnAGgAdAA9AHsAMgAwADAAfQAKACAAIAAgACAAIAAgACAAIAAgACAAIAAgAHgAPQAiADUAMAAlACIACgAgACAAIAAgACAAIAAgACAAIAAgACAAIAB5AD0AewAtADEAfQAKACAAIAAgACAAIAAgACAAIAAgACAAIAAgAHAAYQB0AHQAZQByAG4AVQBuAGkAdABzAD0AIgB1AHMAZQByAFMAcABhAGMAZQBPAG4AVQBzAGUAIgAKACAAIAAgACAAIAAgACAAIAAgACAAPgAKACAAIAAgACAAIAAgACAAIAAgACAAIAAgADwAcABhAHQAaAAgAGQAPQAiAE0ALgA1ACAAMgAwADAAVgAuADUASAAyADAAMAAiACAAZgBpAGwAbAA9ACIAbgBvAG4AZQAiACAALwA%2BAAoAIAAgACAAIAAgACAAIAAgACAAIAA8AC8AcABhAHQAdABlAHIAbgA%2BAAoAIAAgACAAIAAgACAAIAAgADwALwBkAGUAZgBzAD4ACgAgACAAIAAgACAAIAAgACAAPAByAGUAYwB0ACAAdwBpAGQAdABoAD0AIgAxADAAMAAlACIAIABoAGUAaQBnAGgAdAA9ACIAMQAwADAAJQAiACAAcwB0AHIAbwBrAGUAVwBpAGQAdABoAD0AewAwAH0AIABmAGkAbABsAD0AIgB1AHIAbAAoACMAMAA3ADgANwBhADcAYwA1AC0AOQA3ADgAYwAtADQAZgA2ADYALQA4ADMAYwA3AC0AMQAxAGMAMgAxADMAZgA5ADkAYwBiADcAKQAiACAALwA%2BAAoAIAAgACAAIAAgACAAPAAvAHMAdgBnAD4ACgAgACAAKQAKAH0A

Expected result

It should not report an error, since the element is merely visual.

Code of Conduct

  • I agree to follow Biome's Code of Conduct
@unvalley unvalley added good first issue Good for newcomers A-Linter Area: linter L-JavaScript Language: JavaScript and super languages labels Nov 27, 2023
@vasucp1207
Copy link
Member

Can I work on this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Linter Area: linter good first issue Good for newcomers L-JavaScript Language: JavaScript and super languages
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants