Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🐛 Line breaking after extends in type parameters #850

Closed
1 task done
Conaclos opened this issue Nov 23, 2023 · 2 comments · Fixed by #876
Closed
1 task done

🐛 Line breaking after extends in type parameters #850

Conaclos opened this issue Nov 23, 2023 · 2 comments · Fixed by #876
Assignees
@Yuiki
Labels
A-Formatter Area: formatter L-JavaScript Language: JavaScript and super languages S-Bug-confirmed Status: report has been confirmed as a valid bug S-Help-wanted Status: you're familiar with the code base and want to help the project

Comments

@Conaclos
Copy link
Member

Conaclos commented Nov 23, 2023 •
edited
Loading

Environment information

Playground

What happened?

Biome doesn't break on extends in type parameter when line got too large.

Playground link

related Prettier PRs:

Expected result

The following code:

export type OuterType2<
  LongerLongerLongerLongerInnerType extends LongerLongerLongerLongerLongerLongerLongerLongerOtherType
> = { a: 1 };

should be formatted as Prettier:

export type OuterType2<
	LongerLongerLongerLongerInnerType extends
		LongerLongerLongerLongerLongerLongerLongerLongerOtherType,
> = { a: 1 };

Code of Conduct

  • I agree to follow Biome's Code of Conduct
@Conaclos Conaclos added S-Help-wanted Status: you're familiar with the code base and want to help the project A-Formatter Area: formatter L-JavaScript Language: JavaScript and super languages S-Bug-confirmed Status: report has been confirmed as a valid bug labels Nov 23, 2023
@Yuiki
Copy link
Contributor

Yuiki commented Nov 25, 2023

Can I address this issue?

@Conaclos
Copy link
Member Author

You are welcome :)

@Yuiki Yuiki mentioned this issue Nov 25, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Yuiki Yuiki

Labels
A-Formatter Area: formatter L-JavaScript Language: JavaScript and super languages S-Bug-confirmed Status: report has been confirmed as a valid bug S-Help-wanted Status: you're familiar with the code base and want to help the project
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(formatter): Line breaking after extends in type parameters Yuiki/biome
2 participants
@Conaclos @Yuiki