fix(biome_js_analyze): update noUselessFragments's action logic to avoid the panic #595
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fix #459
Previously, I modified the logic that convert JsxText to JsxString (ref: rome/tools#4662), but it seem it is not correct. Basically, we should convert JsxText to JsStringLiteral. If JsxText is part of JsxAttributeValue, we convert JsxText to JsxString
Test Plan
I confirmed the panic doesn't happened using binary built in my local.
The confirmed snippets