Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Order of operations issue: ignored files and files.maxSize #4773

Open
1 task done
janie314 opened this issue Dec 21, 2024 · 0 comments
Open
1 task done

🐛 Order of operations issue: ignored files and files.maxSize #4773

janie314 opened this issue Dec 21, 2024 · 0 comments
Labels
S-Needs triage Status: this issue needs to be triaged

Comments

@janie314
Copy link
Contributor

Environment information

CLI:
  Version:                      1.9.4
  Color support:                true

Platform:
  CPU Architecture:             x86_64
  OS:                           linux

Environment:
  BIOME_LOG_PATH:               unset
  BIOME_LOG_PREFIX_NAME:        unset
  BIOME_CONFIG_PATH:            unset
  NO_COLOR:                     unset
  TERM:                         "tmux-256color"
  JS_RUNTIME_VERSION:           "v22.9.0"
  JS_RUNTIME_NAME:              "node"
  NODE_PACKAGE_MANAGER:         "bun/1.1.42"

Biome Configuration:
  Status:                       Loaded successfully
  Formatter disabled:           false
  Linter disabled:              false
  Organize imports disabled:    false
  VCS disabled:                 true

Workspace:
  Open Documents:               0

What happened?

If a file is ignored per biome.json settings, but is too large per Biome's files.maxSize setting, that file can still cause biome ci to error out.
 
Run both (1) bun run biome ci and (2) bun run biome ci --files-max-size=10000000 in this repo. (1) errors out but (2) does not.

Expected result

Both (1) and (2) should not error out because out.json is ignored per biome.json settings.

Code of Conduct

  • I agree to follow Biome's Code of Conduct
@janie314 janie314 added the S-Needs triage Status: this issue needs to be triaged label Dec 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-Needs triage Status: this issue needs to be triaged
Projects
None yet
Development

No branches or pull requests

1 participant