Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Editorconfig fails to parse max_line_length = off #3904

Closed
1 task done
dyc3 opened this issue Sep 15, 2024 · 3 comments · Fixed by #3907
Closed
1 task done

🐛 Editorconfig fails to parse max_line_length = off #3904

dyc3 opened this issue Sep 15, 2024 · 3 comments · Fixed by #3907
Assignees
Labels
A-Project Area: project S-Bug-confirmed Status: report has been confirmed as a valid bug

Comments

@dyc3
Copy link
Contributor

dyc3 commented Sep 15, 2024

Environment information

N/A

What happened?

  1. use this editorconfig
root = true

[*]
max_line_length = off
  1. biome format --use-editorconfig
  2. see parsing failure

Expected result

It should at minimum emit a warning diagnostic.

Code of Conduct

  • I agree to follow Biome's Code of Conduct
@dyc3 dyc3 added A-Project Area: project S-Bug-confirmed Status: report has been confirmed as a valid bug labels Sep 15, 2024
@dyc3 dyc3 self-assigned this Sep 15, 2024
@chrisgrieser
Copy link

Adding to this issue instead of opening one of my own as I assume this is related:

when setting max_line_length to a value, that value is respected when using biome --format, but ignored when using the biome LSP from inside the editor.

@dyc3
Copy link
Contributor Author

dyc3 commented Sep 16, 2024

@chrisgrieser That sounds like a separate issue. If you could open a new one so we can keep track of it that would be great!

@chrisgrieser
Copy link

Sure, opened a separate issue: #3923

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Project Area: project S-Bug-confirmed Status: report has been confirmed as a valid bug
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants