Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

📝 useEditorconfig does not work with biome ci #3864

Closed
1 task done
mrazauskas opened this issue Sep 13, 2024 · 2 comments · Fixed by #3870
Closed
1 task done

📝 useEditorconfig does not work with biome ci #3864

mrazauskas opened this issue Sep 13, 2024 · 2 comments · Fixed by #3870
Assignees
Labels
A-CLI Area: CLI S-Bug-confirmed Status: report has been confirmed as a valid bug

Comments

@mrazauskas
Copy link
Contributor

Environment information

CLI:
  Version:                      1.9.0
  Color support:                true

Platform:
  CPU Architecture:             aarch64
  OS:                           macos

Environment:
  BIOME_LOG_PATH:               unset
  BIOME_LOG_PREFIX_NAME:        unset
  BIOME_CONFIG_PATH:            unset
  NO_COLOR:                     unset
  TERM:                         "xterm-256color"
  JS_RUNTIME_VERSION:           "v20.17.0"
  JS_RUNTIME_NAME:              "node"
  NODE_PACKAGE_MANAGER:         "yarn/4.4.1"

Biome Configuration:
  Status:                       Loaded successfully
  Formatter disabled:           false
  Linter disabled:              false
  Organize imports disabled:    false
  VCS disabled:                 true

Formatter:
  Format with errors:           false
  Indent style:                 Tab
  Indent width:                 2
  Line ending:                  Lf
  Line width:                   80
  Attribute position:           Auto
  Bracket spacing:              BracketSpacing(true)
  Ignore:                       []
  Include:                      []

JavaScript Formatter:
  Enabled:                      true
  JSX quote style:              Double
  Quote properties:             AsNeeded
  Trailing commas:              All
  Semicolons:                   Always
  Arrow parentheses:            Always
  Bracket spacing:              unset
  Bracket same line:            false
  Quote style:                  Double
  Indent style:                 unset
  Indent width:                 unset
  Line ending:                  unset
  Line width:                   unset
  Attribute position:           unset

JSON Formatter:
  Enabled:                      true
  Indent style:                 unset
  Indent width:                 unset
  Line ending:                  unset
  Line width:                   unset
  Trailing Commas:              unset

CSS Formatter:
  Enabled:                      true
  Indent style:                 unset
  Indent width:                 unset
  Line ending:                  unset
  Line width:                   unset
  Quote style:                  Double

GraphQL Formatter:
  Enabled:                      false
  Indent style:                 unset
  Indent width:                 unset
  Line ending:                  unset
  Line width:                   unset
  Bracket spacing:              unset
  Quote style:                  unset

Workspace:
  Open Documents:               0

Configuration

{
  "formatter": {
    "enabled": true,
    "useEditorconfig": true
  }
}

Playground link

tstyche/tstyche#301

Code of Conduct

  • I agree to follow Biome's Code of Conduct
@mrazauskas
Copy link
Contributor Author

mrazauskas commented Sep 13, 2024

Seems like this is only an issue with biome ci. biome format and biome check work as expected. Not reproducible in the playground.

The change in the PR is minimal. Please check out that branch and run yarn biome ci. The failure is reproducible locally.

Interestingly, yarn biome format and yarn biome check are running without errors. And it looks like biome ci only complains about formatting of JSON files.

I also tried yarn biome ci --use-editorconfig true, but seems like that has no effect.

@eMerzh
Copy link
Contributor

eMerzh commented Sep 13, 2024

Similar here...
got a repro repository if needed
https://github.com/eMerzh/biome-repro-1726173024602

@dyc3 dyc3 added A-CLI Area: CLI S-Bug-confirmed Status: report has been confirmed as a valid bug labels Sep 13, 2024
@dyc3 dyc3 self-assigned this Sep 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-CLI Area: CLI S-Bug-confirmed Status: report has been confirmed as a valid bug
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants