Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🐛 useSemanticElements false alarm on role="alert" #3858

Closed
1 task done
baileys-li opened this issue Sep 12, 2024 · 3 comments · Fixed by #3868 or #4078
Closed
1 task done

🐛 useSemanticElements false alarm on role="alert" #3858

baileys-li opened this issue Sep 12, 2024 · 3 comments · Fixed by #3868 or #4078
Assignees
@Conaclos
Labels
A-Linter Area: linter L-JavaScript Language: JavaScript and super languages S-Bug-confirmed Status: report has been confirmed as a valid bug

Comments

@baileys-li
Copy link

baileys-li commented Sep 12, 2024 •
edited
Loading

What happened?

✖ The elements with the following roles can be changed to the following elements: <alert>

— Playground

Expected result

There is html element <alert> neither in MDN, nor in HTML Spec. So lint/a11y/useSemanticElements should do nothing with alert role tho

Code of Conduct

  • I agree to follow Biome's Code of Conduct
@Conaclos Conaclos added A-Linter Area: linter L-JavaScript Language: JavaScript and super languages S-Bug-confirmed Status: report has been confirmed as a valid bug labels Sep 12, 2024
@ematipico
Copy link
Member

It should be dialog, right?

@baileys-li
Copy link
Author

@ematipico I guess it's better not to force any tag at all.
For example it's could be any tag with popup attribute

@Conaclos Conaclos self-assigned this Sep 13, 2024
@Conaclos Conaclos mentioned this issue Sep 13, 2024
Merged
@Conaclos Conaclos reopened this Sep 19, 2024
@Conaclos
Copy link
Member

Reopening because my fix (#3868) was ineffective.

@Conaclos Conaclos assigned Conaclos and unassigned Conaclos Sep 19, 2024
@Conaclos Conaclos mentioned this issue Sep 25, 2024
Merged
@WomB0ComB0 WomB0ComB0 mentioned this issue Nov 1, 2024
Open
@WomB0ComB0 WomB0ComB0 mentioned this issue Nov 8, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Conaclos Conaclos

Labels
A-Linter Area: linter L-JavaScript Language: JavaScript and super languages S-Bug-confirmed Status: report has been confirmed as a valid bug
Projects
None yet
Milestone
No milestone
3 participants
@ematipico @Conaclos @baileys-li