Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Align with prettier 3.3.3 on adding parentheses for nullish coalescing in ternary #3742

Closed
1 task done
kbrilla opened this issue Aug 30, 2024 · 1 comment · Fixed by #3765
Closed
1 task done

Align with prettier 3.3.3 on adding parentheses for nullish coalescing in ternary #3742

kbrilla opened this issue Aug 30, 2024 · 1 comment · Fixed by #3765
Assignees
Labels
A-Formatter Area: formatter S-Bug-confirmed Status: report has been confirmed as a valid bug S-Help-wanted Status: you're familiar with the code base and want to help the project

Comments

@kbrilla
Copy link

kbrilla commented Aug 30, 2024

Environment information

CLI:
  Version:                      1.8.3
  Color support:                true

Platform:
  CPU Architecture:             aarch64
  OS:                           macos

Environment:
  BIOME_LOG_DIR:                unset
  NO_COLOR:                     unset
  TERM:                         "xterm-256color"
  JS_RUNTIME_VERSION:           "v20.12.1"
  JS_RUNTIME_NAME:              "node"
  NODE_PACKAGE_MANAGER:         "npm/10.8.1"

Biome Configuration:
  Status:                       Loaded successfully
  Formatter disabled:           false
  Linter disabled:              false
  Organize imports disabled:    true
  VCS disabled:                 true

Formatter:
  Format with errors:           true
  Indent style:                 Space
  Indent width:                 2
  Line ending:                  Lf
  Line width:                   120
  Attribute position:           Auto
  Ignore:                       []
  Include:                      []

JavaScript Formatter:
  Enabled:                      false
  JSX quote style:              Double
  Quote properties:             AsNeeded
  Trailing commas:              All
  Semicolons:                   Always
  Arrow parentheses:            Always
  Bracket spacing:              false
  Bracket same line:            false
  Quote style:                  Single
  Indent style:                 unset
  Indent width:                 unset
  Line ending:                  unset
  Line width:                   unset
  Attribute position:           Auto

JSON Formatter:
  Enabled:                      false
  Indent style:                 unset
  Indent width:                 unset
  Line ending:                  unset
  Line width:                   unset
  Trailing Commas:              None

CSS Formatter:
  Enabled:                      false
  Indent style:                 unset
  Indent width:                 unset
  Line ending:                  unset
  Line width:                   unset
  Quote style:                  Double

Workspace:
  Open Documents:               0

Configuration

{
  "formatter": {
    "indentStyle": "space",
    "formatWithErrors": true,
    "lineWidth": 120,
    "indentWidth": 2
  },
  "javascript": {
    "formatter": {
      "quoteStyle": "single"
    }
  },
  "json": {
    "formatter": {
      "trailingCommas": "none"
    }
  },
  "organizeImports": {
    "enabled": false
  }
}

Playground link

https://biomejs.dev/playground/?code=LwAvACAASQBuAHAAdQB0AAoAZgBvAG8AIAA%2FACAAYgBhAHIAIAA%2FAD8AIABmAG8AbwAgADoAIABiAGEAegA7AAoAZgBvAG8AIAA%2FAD8AIABiAGEAcgAgAD8AIABhACAAOgAgAGIAOwAKAGEAIAA%2FACAAYgAgADoAIABmAG8AbwAgAD8APwAgAGIAYQByADsA

Code of Conduct

  • I agree to follow Biome's Code of Conduct
@kbrilla
Copy link
Author

kbrilla commented Aug 30, 2024

@Conaclos Conaclos added A-Formatter Area: formatter S-Enhancement Status: Improve an existing feature S-Bug-confirmed Status: report has been confirmed as a valid bug S-Help-wanted Status: you're familiar with the code base and want to help the project and removed S-Enhancement Status: Improve an existing feature labels Aug 30, 2024
@Conaclos Conaclos self-assigned this Sep 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Formatter Area: formatter S-Bug-confirmed Status: report has been confirmed as a valid bug S-Help-wanted Status: you're familiar with the code base and want to help the project
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants