Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

📎 Implement nursery/useConsistentMemberAccessibility - explicit-member-accessibility #3271

Closed
Conaclos opened this issue Jun 24, 2024 · 2 comments · Fixed by #3536
Closed
Assignees
Labels
A-Linter Area: linter L-JavaScript Language: JavaScript and super languages S-Help-wanted Status: you're familiar with the code base and want to help the project

Comments

@Conaclos
Copy link
Member

Description

Implement explicit-member-accessibility

Want to contribute? Lets you know you are interested! We will assign you to the issue to prevent several people to work on the same issue. Don't worry, we can unassign you later if you are no longer interested in the issue! Read our contributing guide and analyzer contributing guide.

Important

We will skip most of the options implemented by ESLint

I propose to implement a single option accessibility taking a value among:

  • explicit: requires an accessibility modifier for every member that allows that (a safe fix will add public).
  • none: forbid all accessibility modifiers (public, protecetd, public).
  • noPublic: forbid the use of public (a safe fix will remove it).

In contrast to the ESLint rule, I think we should use noPublic as the default because the omission of public1 is more common than its explicit use.

Note that we should always ignore parameter properties in constructors.

@Conaclos Conaclos added A-Linter Area: linter L-JavaScript Language: JavaScript and super languages S-Help-wanted Status: you're familiar with the code base and want to help the project labels Jun 24, 2024
@seitarof
Copy link
Contributor

@Conaclos
Hi.
Can I work on this issue?

@Conaclos
Copy link
Member Author

All yours :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Linter Area: linter L-JavaScript Language: JavaScript and super languages S-Help-wanted Status: you're familiar with the code base and want to help the project
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants