Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 biome ci . --colors=off outputting colors #3232

Closed
1 task done
alechartung opened this issue Jun 17, 2024 · 5 comments · Fixed by #3244 · 4 remaining pull requests
Closed
1 task done

🐛 biome ci . --colors=off outputting colors #3232

alechartung opened this issue Jun 17, 2024 · 5 comments · Fixed by #3244 · 4 remaining pull requests
Assignees
Labels
A-CLI Area: CLI good first issue Good for newcomers S-Bug-confirmed Status: report has been confirmed as a valid bug

Comments

@alechartung
Copy link

Environment information

CLI:
  Version:                      1.8.1
  Color support:                true

Platform:
  CPU Architecture:             x86_64
  OS:                           linux

Environment:
  BIOME_LOG_DIR:                unset
  NO_COLOR:                     unset
  TERM:                         "foot"
  JS_RUNTIME_VERSION:           "v22.3.0"
  JS_RUNTIME_NAME:              "node"
  NODE_PACKAGE_MANAGER:         "npm/10.8.1"

Biome Configuration:
  Status:                       Loaded successfully
  Formatter disabled:           false
  Linter disabled:              false
  Organize imports disabled:    false
  VCS disabled:                 false

Workspace:
  Open Documents:               0

What happened?

  1. run biome ci . --colors=off
  2. "Checked 1493 files in 262ms. No fixes needed." text is purple
    20240617_16h53m22s_grim

Expected result

Output shouldn't have colors.

Code of Conduct

  • I agree to follow Biome's Code of Conduct
@ematipico
Copy link
Member

That's intended, we enforce the colours in the ci command. Is there a reason why you want to turn off the colours in CI?

@ematipico ematipico added the S-Needs response Status: await response from OP label Jun 18, 2024
@alechartung
Copy link
Author

I'm capturing the output of the CI job to put into a comment, and this is what I'm getting now:

20240618_11h51m35s_grim

@ematipico
Copy link
Member

ematipico commented Jun 18, 2024

I see, thank you for the explanation.

I believe the fix should still force the colours, but only if the user hasn't provided them via CLI. If the user provides it, we should use it

@ematipico ematipico added A-CLI Area: CLI S-Bug-confirmed Status: report has been confirmed as a valid bug and removed S-Needs response Status: await response from OP labels Jun 18, 2024
@Sec-ant
Copy link
Member

Sec-ant commented Jun 18, 2024

@ematipico Is this possibly the reason why the github reporter doesn't work? #3148

@ematipico ematipico added the good first issue Good for newcomers label Jun 18, 2024
@ematipico
Copy link
Member

I don't know, it could be

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment