Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

📝 CSS formatter converts custom identifiers to lowercase #3184

Closed
1 task done
joshwooding opened this issue Jun 12, 2024 · 3 comments · Fixed by #3254 · 4 remaining pull requests
Closed
1 task done

📝 CSS formatter converts custom identifiers to lowercase #3184

joshwooding opened this issue Jun 12, 2024 · 3 comments · Fixed by #3254 · 4 remaining pull requests
Labels
A-Formatter Area: formatter L-CSS Language: CSS S-Bug-confirmed Status: report has been confirmed as a valid bug

Comments

@joshwooding
Copy link

Environment information

Playground link

Configuration

No response

Playground link

https://biomejs.dev/playground/?files.main.css=LgBjAG8AbgB0AGEAaQBuAGUAcgAgAHsACgAgACAAZwByAGkAZAAtAHQAZQBtAHAAbABhAHQAZQAtAGEAcgBlAGEAcwA6ACAAIgBsAGEAYgBlAGwAIABmAG8AcgBtAEMAbwBuAHQAcgBvAGwAIgAKAH0ACgAKAC4AYwBvAG4AdABhAGkAbgBlAHIAIABpAG4AcAB1AHQAIAB7AAoAIAAgAGcAcgBpAGQALQBhAHIAZQBhADoAIABmAG8AcgBtAEMAbwBuAHQAcgBvAGwAOwAKAH0A

Code of Conduct

  • I agree to follow Biome's Code of Conduct
@joshwooding
Copy link
Author

Potentially related issue/solution: #3068

@ematipico ematipico added good first issue Good for newcomers A-Formatter Area: formatter L-CSS Language: CSS S-Bug-confirmed Status: report has been confirmed as a valid bug labels Jun 12, 2024
@denbezrukov
Copy link
Contributor

denbezrukov commented Jun 13, 2024

@ematipico

Hmm,

I’m not sure that this is the best or easiest solution here. I think we have two ways to solve it:

  1. Don’t change the case at all.
  2. Change the case only for reserved words. However, to achieve this, we have to know all of them inside the parser/formatter.

@ematipico ematipico removed the good first issue Good for newcomers label Jun 13, 2024
@ematipico
Copy link
Member

Don’t change the case at all.

Maybe we should evaluate this solution. The formatter doesn't have any semantic knowledge of the document, so I suppose any "unknown" things should be left untouched.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment