Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 biome lsp-proxy hangs with certain input #3169

Closed
1 task done
jscheid opened this issue Jun 11, 2024 · 0 comments · Fixed by #3741
Closed
1 task done

🐛 biome lsp-proxy hangs with certain input #3169

jscheid opened this issue Jun 11, 2024 · 0 comments · Fixed by #3741
Assignees
Labels
A-LSP Area: language server protocol S-Bug-confirmed Status: report has been confirmed as a valid bug S-Help-wanted Status: you're familiar with the code base and want to help the project

Comments

@jscheid
Copy link

jscheid commented Jun 11, 2024

Environment information

CLI:
  Version:                      1.8.1
  Color support:                true

Platform:
  CPU Architecture:             aarch64
  OS:                           macos

Environment:
  BIOME_LOG_DIR:                unset
  NO_COLOR:                     unset
  TERM:                         "xterm-256color"
  JS_RUNTIME_VERSION:           unset
  JS_RUNTIME_NAME:              unset
  NODE_PACKAGE_MANAGER:         unset

Biome Configuration:
  Status:                       unset

Workspace:
  Open Documents:               0

What happened?

#!/bin/sh

(
  printf 'Content-Length: 75\r\n\r\n{"jsonrpc":"2.0","id":1,"method":"initialize","params":{"capabilities":{}}}' && \
    printf 'Content-Length: 54\r\n\r\n{"jsonrpc":"2.0","method":"initialized","params":null}' && sleep 1 && \
    printf 'Content-Length: 140\r\n\r\n{"jsonrpc":"2.0","method":"textDocument/didOpen","params":{"textDocument":{"uri":"file:///a.rs","languageId":"rust","version":0,"text":""}}}'
) | biome lsp-proxy

Running the above hangs indefinitely here on my system. It works as expected if I change the languageId to javascript (and adjust the Content-Length of the third message from 140 to 146.)

I understand that biome isn't supporting Rust but the server shouldn't hang.

Expected result

Server doesn't hang, maybe it should return an error instead or maybe it should ignore the wrong languageId.

Code of Conduct

  • I agree to follow Biome's Code of Conduct
@Sec-ant Sec-ant added S-Help-wanted Status: you're familiar with the code base and want to help the project A-LSP Area: language server protocol S-Bug-confirmed Status: report has been confirmed as a valid bug labels Jun 14, 2024
@ematipico ematipico self-assigned this Aug 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-LSP Area: language server protocol S-Bug-confirmed Status: report has been confirmed as a valid bug S-Help-wanted Status: you're familiar with the code base and want to help the project
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants