Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

📎 Implement declaration-block-no-shorthand-property-overrides #2807

Closed
Tracked by #2511
togami2864 opened this issue May 10, 2024 · 5 comments · Fixed by #2958
Closed
Tracked by #2511

📎 Implement declaration-block-no-shorthand-property-overrides #2807

togami2864 opened this issue May 10, 2024 · 5 comments · Fixed by #2958
Assignees
@neoki07
Labels
A-Analyzer Area: analyzer A-Linter Area: linter L-CSS Language: CSS S-Help-wanted Status: you're familiar with the code base and want to help the project

Comments

@togami2864
Copy link
Contributor

togami2864 commented May 10, 2024 •
edited
Loading

Description

Implement declaration-block-no-shorthand-property-overrides

Important

  • Please skip implementing options for now since we will evaluate users actually want them later.
  • Please ignore handling extended CSS language cases such as sass and less.
  • Please skip custom function since we haven't syntax model yet.

Want to contribute? Lets you know you are interested! We will assign you to the issue to prevent several people to work on the same issue. Don't worry, we can unassign you later if you are no longer interested in the issue! Read our contributing guide and analyzer contributing guide.
@togami2864 togami2864 mentioned this issue May 10, 2024
Open
34 tasks
@togami2864 togami2864 added S-Help-wanted Status: you're familiar with the code base and want to help the project A-Linter Area: linter L-CSS Language: CSS A-Analyzer Area: analyzer labels May 10, 2024
@neoki07
Copy link
Contributor

neoki07 commented May 19, 2024

Hello! I'm interested in tackling this issue.

@ematipico
Copy link
Member

We should come up with a better name. The current name is very long. What do you suggest @togami2864 ?

@togami2864
Copy link
Contributor Author

How about noShorthandPropertyOverrides? I think it's fine not to include declaration-block since there's only one override rule.

@neoki07 neoki07 mentioned this issue May 23, 2024
Merged
@neoki07
Copy link
Contributor

neoki07 commented May 29, 2024

I've pushed to #2958 an implementation that handles the basic patterns, though there are still some issues remaining. Could you review the PR and check my approach? Additionally, I've left some comments on the PR with questions. I would appreciate it if you could check those as well.

@ematipico
Copy link
Member

@neokidev I answered some of your questions

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@neoki07 neoki07

Labels
A-Analyzer Area: analyzer A-Linter Area: linter L-CSS Language: CSS S-Help-wanted Status: you're familiar with the code base and want to help the project
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(biome_css_analyzer): noShorthandPropertyOverrides neoki07/biome
3 participants
@ematipico @neoki07 @togami2864