Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Eslint Migraition adding prefix "eslint-config-" when package have only "eslint-config" as name #2705

Closed
hitesh-sourcefuse opened this issue May 4, 2024 · 0 comments · Fixed by #2713
Assignees
Labels
A-Project Area: project S-Bug-confirmed Status: report has been confirmed as a valid bug

Comments

@hitesh-sourcefuse
Copy link

Environment information

CLI:
  Version:                      1.7.2
  Color support:                true

Platform:
  CPU Architecture:             x86_64
  OS:                           linux

Environment:
  BIOME_LOG_DIR:                unset
  NO_COLOR:                     unset
  TERM:                         "xterm-256color"
  JS_RUNTIME_VERSION:           "v20.12.0"
  JS_RUNTIME_NAME:              "node"
  NODE_PACKAGE_MANAGER:         "npm/10.5.0"

Biome Configuration:
  Status:                       Loaded successfully
  Formatter disabled:           false
  Linter disabled:              false
  Organize imports disabled:    false
  VCS disabled:                 true

Workspace:
  Open Documents:               0

What happened?

1: Setup loopback service using "https://loopback.io/doc/en/lb4/Getting-started.html"
2: run "npx @biomejs/biome migrate eslint --write --include-inspired"
3: Update .eslintrc.js as following

module.exports = {
  extends: [
    'eslint:recommended',
    'plugin:@typescript-eslint/recommended',
    '@loopback/eslint-config',
  ],
  parser: '@typescript-eslint/parser',
  plugins: ['@typescript-eslint'],
  root: true,
  rules: {
    '@typescript-eslint/no-misused-promises': [
      2,
      {
        checksVoidReturn: {
          attributes: false,
        },
      },
    ],
    '@typescript-eslint/no-unsafe-assignment': 'off',
    '@typescript-eslint/no-explicit-any': 'off',
    '@typescript-eslint/prefer-nullish-coalescing': 'off',
    '@typescript-eslint/naming-convention': 'off',
  },
  overrides: [
    {
      files: ['*.ts'], // Your TypeScript files extension

      parserOptions: {
        project: ['tsconfig.json'], // Specify it only for TypeScript files
        tsconfigRootDir: __dirname,
      },
    },
  ],
};

It will produce the error

migrate ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━

✖ Migration has encountered an error: The module '@loopback/eslint-config-eslint-config' cannot be loaded. Make sure that the module exists.```

### Expected result

Expecting to complate the migration of eslint file 


### Code of Conduct

- [X] I agree to follow Biome's Code of Conduct
@Conaclos Conaclos added A-Project Area: project S-Bug-confirmed Status: report has been confirmed as a valid bug labels May 4, 2024
@Conaclos Conaclos self-assigned this May 4, 2024
@Conaclos Conaclos changed the title Esline Migraition adding prefix "eslint-config-" when package have only "eslint-config" as name Eslint Migraition adding prefix "eslint-config-" when package have only "eslint-config" as name May 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Project Area: project S-Bug-confirmed Status: report has been confirmed as a valid bug
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants