Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

📎 Implement lint/useJsxCurlyBraceConvention - react/jsx-curly-brace-presence #2435

Closed
itsyoboieltr opened this issue Apr 13, 2024 · 6 comments · Fixed by #3182
Closed
Assignees
Labels
A-Linter Area: linter S-Feature Status: new feature to implement

Comments

@itsyoboieltr
Copy link

itsyoboieltr commented Apr 13, 2024

Description

Implement react/jsx-curly-brace-presence.

Want to contribute? Lets you know you are interested! We will assign you to the issue to prevent several people to work on the same issue. Don't worry, we can unassign you later if you are no longer interested in the issue! Read our contributing guide and analyzer contributing guide.

I think the original naming is a bit misleading, as this is not only for react. Other frameworks using jsx can benefit from this, like Solid

Suggested name: useJsxCurlyBraceConvention

@ematipico
Copy link
Member

Are you going to implement the rule @itsyoboieltr?

@Geczy
Copy link

Geczy commented Apr 16, 2024

Also looking forward to this a lot! @itsyoboieltr

@itsyoboieltr
Copy link
Author

Unfortunately, I don't have time to commit to this in the near future, but I opened the issue as I would love to see this implemented.

@ematipico
Copy link
Member

Thank you, but usually, we want to go through a discussion first instead of opening tasks without context and agreeing on something. In this case, can you comment here? #3

Maybe someone already expressed interest.

@dyc3
Copy link
Contributor

dyc3 commented Jun 2, 2024

I would like to give this a shot.

@ematipico ematipico added A-Linter Area: linter S-Feature Status: new feature to implement labels Jun 2, 2024
@izakfilmalter
Copy link

Busy migrating from es-lint / prettier to biome. Could we get an option similare to 'always' from react/jsx-curly-brace-presence?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Linter Area: linter S-Feature Status: new feature to implement
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants