Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🐛 lint/noBarrelFile reports files that are not barrel files #1982

Closed
1 task done
Conaclos opened this issue Mar 6, 2024 · 4 comments · Fixed by #1993
Closed
1 task done

🐛 lint/noBarrelFile reports files that are not barrel files #1982

Conaclos opened this issue Mar 6, 2024 · 4 comments · Fixed by #1993
Assignees
@togami2864
Labels
A-Linter Area: linter L-JavaScript Language: JavaScript and super languages S-Bug-confirmed Status: report has been confirmed as a valid bug

Comments

@Conaclos
Copy link
Member

Conaclos commented Mar 6, 2024

Environment information

Playground

What happened?

A file without re-export is reported.

Playground

Expected result

Files without re-exports should not be reported.

Code of Conduct

  • I agree to follow Biome's Code of Conduct
@Conaclos Conaclos added A-Linter Area: linter L-JavaScript Language: JavaScript and super languages S-Bug-confirmed Status: report has been confirmed as a valid bug labels Mar 6, 2024
@Conaclos
Copy link
Member Author

Conaclos commented Mar 6, 2024

@togami2864 You could be interested in this issue :)

@Conaclos
Copy link
Member Author

Conaclos commented Mar 6, 2024

By the way, we should certainly skip declaration files (.d.ts).

@ematipico
Copy link
Member

@togami2864 To understand what kind of file the analyzer is analysing, you can use this API:

let file_source = ctx.source_type::<JsFileSource>();

@togami2864
Copy link
Contributor

Thank you for reporting! This bug is misleading:(

@togami2864 togami2864 self-assigned this Mar 6, 2024
@togami2864 togami2864 mentioned this issue Mar 7, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@togami2864 togami2864

Labels
A-Linter Area: linter L-JavaScript Language: JavaScript and super languages S-Bug-confirmed Status: report has been confirmed as a valid bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: handle export clause correctly in noBarrelFile togami2864/biome
3 participants
@ematipico @Conaclos @togami2864