Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

📝 Comments between function parens and body should be consistently placed #1172

Closed
1 task done
Conaclos opened this issue Dec 13, 2023 · 1 comment · Fixed by #1485
Closed
1 task done

📝 Comments between function parens and body should be consistently placed #1172

Conaclos opened this issue Dec 13, 2023 · 1 comment · Fixed by #1485
Assignees
@kalleep
Labels
A-Formatter Area: formatter L-JavaScript Language: JavaScript and super languages S-Bug-confirmed Status: report has been confirmed as a valid bug

Comments

@Conaclos
Copy link
Member

Conaclos commented Dec 13, 2023 •
edited
Loading

Environment information

Playground

Configuration

Default configuration

DEscription

Playground link

This leads to non-idempotent formatting.

Code of Conduct

  • I agree to follow Biome's Code of Conduct
@Conaclos Conaclos added A-Formatter Area: formatter L-JavaScript Language: JavaScript and super languages S-Bug-confirmed Status: report has been confirmed as a valid bug labels Dec 13, 2023
@kalleep
Copy link
Contributor

kalleep commented Jan 8, 2024

I can tackle this one

@kalleep kalleep mentioned this issue Jan 9, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kalleep kalleep

Labels
A-Formatter Area: formatter L-JavaScript Language: JavaScript and super languages S-Bug-confirmed Status: report has been confirmed as a valid bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(js_formatter): placements of line comments between function parentheses and body kalleep/biome
2 participants
@Conaclos @kalleep