FR: document formatting capability for the biome lsp-proxy

[chrisgrieser]

Not sure which issue type this belongs to, so opening a discussion here first.

While biome doubles as a CLI and as an LSP, only the linting/analyzing capabilities are accessible via CLI and LSP. Formatting capabilities are only accessible via CLI, since biome apparently does not register the document formatting lsp server capability.

So for the editor integration of biome, this results in the somewhat awkward situation where I integrate linting via the lsp-client, and formatting via the formatting-client of my editor. (Which, in the case of nvim, require totally different plugins.)

---

relevant docs: https://microsoft.github.io/language-server-protocol/specifications/lsp/3.17/specification/#textDocument_formatting

[ematipico]

Biome does support formatting via LSP

biome/crates/rome_lsp/src/server.rs

Lines 148 to 156 in dd9330f

	capabilities.add_capability(
	"rome_formatting",
	"textDocument/formatting",
	if self.session.is_linting_and_formatting_disabled() {
	CapabilityStatus::Disable
	} else {
	CapabilityStatus::Enable(None)
	},
	);

It's possible that your client is not able to register to this event because it doesn't support dynamic registration of the events

biome/crates/rome_lsp/src/session.rs

Lines 358 to 365 in dd9330f

	pub(crate) fn can_register_did_change_configuration(&self) -> bool {
	self.initialize_params
	.get()
	.and_then(|c| c.client_capabilities.workspace.as_ref())
	.and_then(|c| c.did_change_configuration)
	.and_then(|c| c.dynamic_registration)
	== Some(true)
	}

[chrisgrieser]

I see, yeah, so it (mostly) works in nvim 0.10, so this can be considered solved I guess.

(The not-working import-sort is maybe worth a bug report?)

[musjj]

I still can't tell if it's a bug yet. In biome, import sorting is not a part of the formatter, unlike prettier, so the formatter understandably doesn't sort the imports. Not sure if this is possible via the LSP or if it's just not implemented yet. Tbh, I wish they'd just make import sorting a part of the formatter.

[Conaclos]

Import sorting is not part of the formatter because it can produce a code that behaves differently; Although this is rare. You can organize imports via the LSP thanks to the dedicated action organize import. On CLI, you must apply unsafe fixes using biome check --apply-unsafe. In the next release, the code fix will be flagged as safe. You will be able to execute it using ``biome check --apply`.

[musjj]

I tried to view the available code actions, but I can't find the organize import action. I know the biome LSP is functioning, because I can see code actions for other linting actions.

I also tried to move my cursor towards the top of the file (where the imports are), but I also still can't trigger that specific code action. I'm using 1.2.2, maybe this feature is available in later versions?

[binarious]

Have you found a solution? And also: Does biome raise formatting violations as diagnostics for you? I only see linting issues. vim.lsp.buf.format works though.

Edit: Just doesn't seem to be implemented: #809

[ematipico]

@chrisgrieser Do you still need this feature? I think we are going to drop the requireConfiguration option we have in the VSCode extension, this means we can drop the dynamic capability of the LSP.

[chrisgrieser]

yes, would still be nice! Though it's not high priority for me, since nvim 0.10 (still nightly) will support dynamic capabilities.

Nevertheless, if it is possible to drop the requirement, doing so might be useful for other editors that do not have complete LSP support, like nvim prior to 0.10?