AST js import nodes

[Conaclos]

Actually, there are two ways of representing a namespace import such as import * as X from ....
Moreover, the current AST doesn't rule out the invalid states import type D, * as A from ... and import type D, {A} from ....
This is also slightly different from the spec.

I propose a simple change that keeps most of the current nodes and solves these issues:

JsImport =
    'import'
    import_clause: AnyJsImportClause
    ';'?

AnyJsImportClause =
    JsImportBareClause
    | JsImportDefaultClause
    | JsImportNamespaceClause
    | JsImportNamedClause
+   | JsImportDefaultExtraClause

JsImportBareClause =
	  source: JsModuleSource
	  assertion: JsImportAssertion?

JsImportDefaultClause =
    'type'?
-   local_name: AnyJsBinding
+   default_specifier: JsDefaultImportSpecifier
    'from'
    source: JsModuleSource
    assertion: JsImportAssertion?

JsImportNamespaceClause =
    'type'?
-   '*'
-   'as'
-   local_name: AnyJsBinding
+   namespace_specifier: JsNamespaceImportSpecifier
    'from'
    source: JsModuleSource
    assertion: JsImportAssertion?

JsImportNamedClause =
    'type'?
-   default_specifier: JsDefaultImportSpecifier?
-   named_import: AnyJsNamedImport
+   named_specifiers: JsNamedImportSpecifiers
    'from'
    source: JsModuleSource
    assertion: JsImportAssertion?

- AnyJsNamedImport =
+ AnyJsExtraImportSpecifier
   JsNamedImportSpecifiers
   |  JsNamespaceImportSpecifier

+ JsImportDefaultExtraClause =
+   default_specifier: JsDefaultImportSpecifier
+   ','
+   extra_specifier: AnyJsExtraImportSpecifier
+   ''from'
+   source: JsModuleSource
+   assertion: JsImportAssertion?

JsDefaultImportSpecifier =
    local_name: AnyJsBinding
-   trailing_comma: ','

JsNamespaceImportSpecifier =
    '*'
    'as'
    local_name: AnyJsBinding

JsNamedImportSpecifiers =
    '{'
    specifiers: JsNamedImportSpecifierList
    '}'

[Conaclos]

A second approach that factorizes the from clause could look like:

JsImport =
    'import'
    body: AnyJsImportBody
    ';'?

AnyJsImportBody =
    JsImportBareBody
    | JsImportFromBody
    | TsImportAssignmentBody

JsImportBareBody =
    source: JsModuleSource
    assertion: JsImportAssertion?

JsImportFromBody =
    import_clause: AnyJsImportClause
    'from'
    source: JsModuleSource
    assertion: JsImportAssertion?

TsImportAssignmentBody =
	  'type'?
	  local_name: AnyJsBinding
	  '='
	  module_reference: AnyTsModuleReference

AnyJsImportClause =
    JsDefaultImportClause
    | JsDefaultNamedImportClause
    | JsDefaultNamespaceImportClause
    | JsNamespaceImportClause
    | JsNamedImportClause

JsDefaultImportClause =
    'type'?
    default_specifier: JsDefaultImportSpecifier

JsDefaultNamedImportClause =
    default_specifier: JsDefaultImportSpecifier
    ','
    named_specifiers: JsNamedImportSpecifiers

JsDefaultNamespaceImportClause =
    default_specifier: JsDefaultImportSpecifier
    ','
    namespace_specifier: JsNamespaceImportSpecifier

JsNamespaceImportClause =
    'type'?
    namespace_specifier: JsNamespaceImportSpecifier

JsNamedImportClause =
    'type'?
    named_specifiers: JsNamedImportSpecifiers

JsDefaultImportSpecifier =
    local_name: AnyJsBinding

JsNamespaceImportSpecifier =
    '*'
    'as'
    local_name: AnyJsBinding

JsNamedImportSpecifiers =
    '{'
    specifiers: JsNamedImportSpecifierList
    '}'

[Conaclos]

Implemented in #1163