From e4a7b8db214422409d2494f5341d3d213ec14665 Mon Sep 17 00:00:00 2001 From: Kazuhiro-Mimaki Date: Tue, 7 May 2024 09:57:31 +0900 Subject: [PATCH] Kazuhiro-Mimaki/media-feature-name-no-unknown: add example case --- .../src/lint/nursery/no_unknown_media_feature_name.rs | 4 ++++ crates/biome_css_analyze/src/utils.rs | 2 +- .../tests/specs/nursery/noUnknownMediaFeatureName/valid.css | 3 +++ .../specs/nursery/noUnknownMediaFeatureName/valid.css.snap | 3 +++ 4 files changed, 11 insertions(+), 1 deletion(-) diff --git a/crates/biome_css_analyze/src/lint/nursery/no_unknown_media_feature_name.rs b/crates/biome_css_analyze/src/lint/nursery/no_unknown_media_feature_name.rs index 674fd5a8d863..5d106d462387 100644 --- a/crates/biome_css_analyze/src/lint/nursery/no_unknown_media_feature_name.rs +++ b/crates/biome_css_analyze/src/lint/nursery/no_unknown_media_feature_name.rs @@ -52,6 +52,10 @@ declare_rule! { /// @media (400px <= width <= 700px) {} /// ``` /// + /// ```css + /// @media screen and (-webkit-width > 320px) {} + /// ``` + /// pub NoUnknownMediaFeatureName { version: "next", name: "noUnknownMediaFeatureName", diff --git a/crates/biome_css_analyze/src/utils.rs b/crates/biome_css_analyze/src/utils.rs index 87fc42e86499..f14d932f39bc 100644 --- a/crates/biome_css_analyze/src/utils.rs +++ b/crates/biome_css_analyze/src/utils.rs @@ -136,7 +136,7 @@ pub fn is_media_feature_name(prop: &str) -> bool { } for prefix in VENDER_PREFIXES.iter() { for feature_name in MEDIA_FEATURE_NAMES.iter() { - if input == format!("{}-{}", prefix, feature_name) { + if input == format!("{}{}", prefix, feature_name) { return true; } } diff --git a/crates/biome_css_analyze/tests/specs/nursery/noUnknownMediaFeatureName/valid.css b/crates/biome_css_analyze/tests/specs/nursery/noUnknownMediaFeatureName/valid.css index 95dd6766f002..a565d4bf3da3 100644 --- a/crates/biome_css_analyze/tests/specs/nursery/noUnknownMediaFeatureName/valid.css +++ b/crates/biome_css_analyze/tests/specs/nursery/noUnknownMediaFeatureName/valid.css @@ -7,6 +7,9 @@ @media screen and (min-width: 320px) { } +@media screen and (-webkit-min-width: 320px) { +} + @media only screen and (min-width: 320px) and (max-width: 480px) and (resolution: 150dpi) { } diff --git a/crates/biome_css_analyze/tests/specs/nursery/noUnknownMediaFeatureName/valid.css.snap b/crates/biome_css_analyze/tests/specs/nursery/noUnknownMediaFeatureName/valid.css.snap index 9783f9bc1f22..af7d5f158916 100644 --- a/crates/biome_css_analyze/tests/specs/nursery/noUnknownMediaFeatureName/valid.css.snap +++ b/crates/biome_css_analyze/tests/specs/nursery/noUnknownMediaFeatureName/valid.css.snap @@ -13,6 +13,9 @@ expression: valid.css @media screen and (min-width: 320px) { } +@media screen and (-webkit-min-width: 320px) { +} + @media only screen and (min-width: 320px) and (max-width: 480px) and (resolution: 150dpi) { }