Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

How/where are the class-conditional mean *feature* vectors computed? #15

Open
chnsh opened this issue Aug 7, 2020 · 1 comment
Open

Comments

@chnsh
Copy link

chnsh commented Aug 7, 2020

Hi,

Thank you for releasing the source code of the the paper, it is very helpful.

In the paper, equation 2 mentions that the inputs are forwarded through the feature network, and then a class-wise mean vector is computed which is finally forwarded through the class network.

However, https://github.com/biomedia-mira/masf/blob/master/masf_func.py#L78 shows that the global function is passed the final task logits directly and the mean is computed with respect to the final logits as opposed to the feature vector.

Is this an error in the code or something is incorrect with my understanding? Thanks!

@carrenD
Copy link
Collaborator

carrenD commented May 18, 2021

Hi, thanks for the careful point, class-wise mean vector is a general formulation, we implemented in task logits to make this presentation very high-level, but your point is very interesting, chaning to intermediate features is worth trying!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants