Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Android app: Validate server URLs #193

Closed
StoyanDimitrov opened this issue Mar 30, 2022 · 2 comments
Closed

Android app: Validate server URLs #193

StoyanDimitrov opened this issue Mar 30, 2022 · 2 comments
Labels
android-app ntfy Android app 🪲 bug Something isn't working in-progress 🏃 I'm working on this right now

Comments

@StoyanDimitrov
Copy link
Contributor

Make proper URL validation of the user input in:

  • default server
  • new user for new server

Currently one can add invalid characters in those server URL fields.
@binwiederhier binwiederhier added 🪲 bug Something isn't working android-app ntfy Android app labels Apr 1, 2022
@cmeis cmeis mentioned this issue Apr 8, 2022
Closed
@binwiederhier binwiederhier added the in-progress 🏃 I'm working on this right now label Apr 13, 2022
@binwiederhier
Copy link
Owner

binwiederhier commented Apr 14, 2022 •
edited
Loading

Fixed in binwiederhier/ntfy-android@fc27b0c

@binwiederhier
Copy link
Owner

Note: I opted for keeping a very simple URL validation (basically anything starting with http?://...), because it's too hard and not worth it to do anything else.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
android-app ntfy Android app 🪲 bug Something isn't working in-progress 🏃 I'm working on this right now
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@binwiederhier @StoyanDimitrov