Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PaSh cleanup should remove all nodes #452

Open
nvasilakis opened this issue Feb 2, 2022 · 2 comments
Open

PaSh cleanup should remove all nodes #452

nvasilakis opened this issue Feb 2, 2022 · 2 comments
Assignees
Labels
human-sacrifice Kill children

Comments

@nvasilakis
Copy link
Collaborator

Upon abnormal exit/kill, PaSh should kill the entire process tree under it (without leaving any eager or other commands running).

@angelhof
Copy link
Member

angelhof commented Feb 4, 2022

Note that this is not as straightforward as it might sound! Some notes:

  • It is not clear if this issue still persists or if it only happened in previous versions of pash.
  • The biggest issue with hanging processes is not the daemon and the main pash process, but rather the parallel scripts that contain eagers etc. Therefore, our solution should modify (or use) this https://github.com/binpash/pash/blob/main/runtime/wait_for_output_and_sigpipe_rest.sh or be a trap handler in the output parallel script. For both of those, we should make sure to check for the performance overhead.
  • Our solution should kill all processes of the dataflow graph and wait for them.
  • Our solution should only kill processes that are descendants of the current shell (and no more).

Also, this change should not go to main but to future since it is an experimental change.

@angelhof
Copy link
Member

If we can fix #500, then we should be able to fix this one here too.

@angelhof angelhof changed the title Cleanup kill garbage PaSh cleanup should remove all nodes Feb 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
human-sacrifice Kill children
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants