ci: Update args of golangci-lint in ci.yml (alibaba#535)

Signed-off-by: Jiangnan Jia <[email protected]>

Author: jnan806

.github/workflows/go.yml

@@ -26,7 +26,7 @@ jobs:
         uses: golangci/golangci-lint-action@v3
         with:
           version: latest
-          args: "--out-${NO_FUTURE}format colored-line-number"
+          args: "--out-format colored-line-number"
 
   build:
     name: Build and test - Go ${{ matrix.go_version }}

api/api.go

@@ -117,7 +117,7 @@ func WithAttachment(key interface{}, value interface{}) EntryOption {
 	}
 }
 
-// WithAttachment set the resource entry with the given k-v pairs
+// WithAttachments set the resource entry with the given k-v pairs
 func WithAttachments(data map[interface{}]interface{}) EntryOption {
 	return func(opts *EntryOptions) {
 		if opts.attachments == nil {

core/base/slot_chain.go

@@ -110,7 +110,7 @@ func NewSlotChain() *SlotChain {
 	}
 }
 
-// Get a EntryContext from EntryContext ctxPool, if ctxPool doesn't have enough EntryContext then new one.
+// Get an EntryContext from EntryContext ctxPool, if ctxPool doesn't have enough EntryContext then new one.
 func (sc *SlotChain) GetPooledContext() *EntryContext {
 	ctx := sc.ctxPool.Get().(*EntryContext)
 	ctx.startTime = util.CurrentTimeMillis()

core/circuitbreaker/circuit_breaker.go

@@ -229,7 +229,7 @@ func (b *circuitBreakerBase) fromHalfOpenToOpen(snapshot interface{}) bool {
 	return false
 }
 
-// fromHalfOpenToOpen updates circuit breaker state machine from half-open to closed
+// fromHalfOpenToClosed updates circuit breaker state machine from half-open to closed
 // Return true only if current goroutine successfully accomplished the transformation.
 func (b *circuitBreakerBase) fromHalfOpenToClosed() bool {
 	if b.state.cas(HalfOpen, Closed) {

core/system_metric/sys_metric_stat.go

@@ -78,7 +78,7 @@ func init() {
 	metric_exporter.Register(processMemoryGauge)
 }
 
-// getMemoryStat returns the current machine's memory statistic
+// getTotalMemorySize returns the current machine's memory statistic
 func getTotalMemorySize() (total uint64) {
 	stat, err := mem.VirtualMemory()
 	if err != nil {

ext/datasource/hotspot_rule_converter.go

@@ -93,7 +93,7 @@ func (s *SpecificValue) String() string {
 	return fmt.Sprintf("SpecificValue: [ValKind: %+v, ValStr: %s]", s.ValKind, s.ValStr)
 }
 
-// arseSpecificItems parses the SpecificValue as real value.
+// parseSpecificItems parses the SpecificValue as real value.
 func parseSpecificItems(source []SpecificValue) map[interface{}]int64 {
 	ret := make(map[interface{}]int64, len(source))
 	if len(source) == 0 {

pkg/adapters/micro/options.go

@@ -26,15 +26,15 @@ type (
 	}
 )
 
-// WithUnaryClientResourceExtractor sets the resource extractor of unary client request.
+// WithClientResourceExtractor sets the resource extractor of unary client request.
 // The second string parameter is the full method name of current invocation.
 func WithClientResourceExtractor(fn func(context.Context, client.Request) string) Option {
 	return func(opts *options) {
 		opts.clientResourceExtract = fn
 	}
 }
 
-// WithUnaryServerResourceExtractor sets the resource extractor of unary server request.
+// WithServerResourceExtractor sets the resource extractor of unary server request.
 func WithServerResourceExtractor(fn func(context.Context, server.Request) string) Option {
 	return func(opts *options) {
 		opts.serverResourceExtract = fn
@@ -55,15 +55,15 @@ func WithStreamServerResourceExtractor(fn func(server.Stream) string) Option {
 	}
 }
 
-// WithUnaryClientBlockFallback sets the block fallback handler of unary client request.
+// WithClientBlockFallback sets the block fallback handler of unary client request.
 // The second string parameter is the full method name of current invocation.
 func WithClientBlockFallback(fn func(context.Context, client.Request, *base.BlockError) error) Option {
 	return func(opts *options) {
 		opts.clientBlockFallback = fn
 	}
 }
 
-// WithUnaryServerBlockFallback sets the block fallback handler of unary server request.
+// WithServerBlockFallback sets the block fallback handler of unary server request.
 func WithServerBlockFallback(fn func(context.Context, server.Request, *base.BlockError) error) Option {
 	return func(opts *options) {
 		opts.serverBlockFallback = fn

pkg/datasource/etcdv3/etcdv3.go

@@ -81,7 +81,7 @@ func (s *Etcdv3DataSource) processWatchResponse(resp *clientv3.WatchResponse) {
 	}
 
 	if err := resp.Err(); err != nil {
-		logging.Error(err, "Watch on etcd endpoints occur error", "endpointd", s.client.Endpoints())
+		logging.Error(err, "Watch on etcd endpoints occur error", "endpoints", s.client.Endpoints())
 		return
 	}
 

pkg/datasource/k8s/controllers/hotspotrules_controller.go

@@ -151,7 +151,7 @@ func (r *HotspotRulesReconciler) assembleHotspotRules(rs *datasourcev1.HotspotRu
 	return ret
 }
 
-// arseSpecificItems parses the SpecificValue as real value.
+// parseSpecificItems parses the SpecificValue as real value.
 func parseSpecificItems(source []datasourcev1.SpecificValue) map[interface{}]int64 {
 	ret := make(map[interface{}]int64)
 	if len(source) == 0 {

util/time.go

@@ -255,7 +255,7 @@ func CurrentClock() Clock {
 	return currentClock.Load().(*clockWrapper).clock
 }
 
-// SetClock sets the ticker creator used by util package.
+// SetTickerCreator sets the ticker creator used by util package.
 // In general, no need to set it. It is usually used for testing.
 func SetTickerCreator(tc TickerCreator) {
 	currentTickerCreator.Store(&tickerCreatorWrapper{tc})