Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[R4R]fix validator failed to sync a block produced by itself, resolve #3 #4

Merged
merged 1 commit into from
Jun 15, 2020
Merged

[R4R]fix validator failed to sync a block produced by itself, resolve #3 #4

merged 1 commit into from
Jun 15, 2020

Conversation

unclezoro
Copy link
Collaborator

@unclezoro unclezoro commented Jun 1, 2020 •
edited
Loading

A validator failed to sync a block produced by itself, because in previous logic, we decide if it is mining by whether the producer of the block is the validator of Parlia consensus engine or not.

@unclezoro unclezoro changed the base branch from master to develop June 1, 2020 13:42
@unclezoro unclezoro changed the title [R4R]fix validator failed to sync a block produced by itself [R4R]fix validator failed to sync a block produced by itself, #3 Jun 1, 2020
@unclezoro unclezoro changed the title [R4R]fix validator failed to sync a block produced by itself, #3 [R4R]fix validator failed to sync a block produced by itself, resolve issue 3 Jun 1, 2020
@unclezoro unclezoro changed the title [R4R]fix validator failed to sync a block produced by itself, resolve issue 3 [R4R]fix validator failed to sync a block produced by itself, resolve #3 Jun 1, 2020
@unclezoro unclezoro requested a review from abelliumnt June 1, 2020 13:44
@unclezoro unclezoro requested a review from yutianwu June 2, 2020 08:42
@unclezoro unclezoro merged commit e83397e into develop Jun 15, 2020
@unclezoro unclezoro mentioned this pull request Jul 3, 2020
Merged
@unclezoro unclezoro deleted the issue3 branch July 10, 2020 02:22
unclezoro added a commit that referenced this pull request Jul 23, 2020
@unclezoro
Merge pull request #4 from binance-chain/faucet
5c97c1e 
[R4R]add use fix gas price option for faucet
yutianwu pushed a commit that referenced this pull request May 6, 2021
@rjl493456442 @holiman @karalabe
core, eth: faster snapshot generation (#22504)
7088f1e 
* eth/protocols: persist received state segments

* core: initial implementation

* core/state/snapshot: add tests

* core, eth: updates

* eth/protocols/snapshot: count flat state size

* core/state: add metrics

* core/state/snapshot: skip unnecessary deletion

* core/state/snapshot: rename

* core/state/snapshot: use the global batch

* core/state/snapshot: add logs and fix wiping

* core/state/snapshot: fix

* core/state/snapshot: save generation progress even if the batch is empty

* core/state/snapshot: fixes

* core/state/snapshot: fix initial account range length

* core/state/snapshot: fix initial account range

* eth/protocols/snap: store flat states during the healing

* eth/protocols/snap: print logs

* core/state/snapshot: refactor (#4)

* core/state/snapshot: refactor

* core/state/snapshot: tiny fix and polish

Co-authored-by: rjl493456442 <[email protected]>

* core, eth: fixes

* core, eth: fix healing writer

* core, trie, eth: fix paths

* eth/protocols/snap: fix encoding

* eth, core: add debug log

* core/state/generate: release iterator asap (#5)

core/state/snapshot: less copy

core/state/snapshot: revert split loop

core/state/snapshot: handle storage becoming empty, improve test robustness

core/state: test modified codehash

core/state/snapshot: polish

* core/state/snapshot: optimize stats counter

* core, eth: add metric

* core/state/snapshot: update comments

* core/state/snapshot: improve tests

* core/state/snapshot: replace secure trie with standard trie

* core/state/snapshot: wrap return as the struct

* core/state/snapshot: skip wiping correct states

* core/state/snapshot: updates

* core/state/snapshot: fixes

* core/state/snapshot: fix panic due to reference flaw in closure

* core/state/snapshot: fix errors in state generation logic + fix log output

* core/state/snapshot: remove an error case

* core/state/snapshot: fix condition-check for exhausted snap state

* core/state/snapshot: use stackTrie for small tries

* core/state/snapshot: don't resolve small storage tries in vain

* core/state/snapshot: properly clean up storage of deleted accounts

* core/state/snapshot: avoid RLP-encoding in some cases + minor nitpicks

* core/state/snapshot: fix error (+testcase)

* core/state/snapshot: clean up tests a bit

* core/state/snapshot: work in progress on better tests

* core/state/snapshot: polish code

* core/state/snapshot: fix trie iteration abortion trigger

* core/state/snapshot: fixes flaws

* core/state/snapshot: remove panic

* core/state/snapshot: fix abort

* core/state/snapshot: more tests (plus failing testcase)

* core/state/snapshot: more testcases + fix for failing test

* core/state/snapshot: testcase for malformed data

* core/state/snapshot: some test nitpicks

* core/state/snapshot: improvements to logging

* core/state/snapshot: testcase to demo error in abortion

* core/state/snapshot: fix abortion

* cmd/geth: make verify-state report the root

* trie: fix failing test

* core/state/snapshot: add timer metrics

* core/state/snapshot: fix metrics

* core/state/snapshot: udpate tests

* eth/protocols/snap: write snapshot account even if code or state is needed

* core/state/snapshot: fix diskmore check

* core/state/snapshot: review fixes

* core/state/snapshot: improve error message

* cmd/geth: rename 'error' to 'err' in logs

* core/state/snapshot: fix some review concerns

* core/state/snapshot, eth/protocols/snap: clear snapshot marker when starting/resuming snap sync

* core: add error log

* core/state/snapshot: use proper timers for metrics collection

* core/state/snapshot: address some review concerns

* eth/protocols/snap: improved log message

* eth/protocols/snap: fix heal logs to condense infos

* core/state/snapshot: wait for generator termination before restarting

* core/state/snapshot: revert timers to counters to track total time

Co-authored-by: Martin Holst Swende <[email protected]>
Co-authored-by: Péter Szilágyi <[email protected]>
unclezoro referenced this pull request in unclezoro/bsc Nov 3, 2021
@unclezoro
Merge pull request #4 from binance-chain/mev
76951bd 
[R4R] add mev module
flywukong pushed a commit to flywukong/bsc that referenced this pull request Mar 11, 2022
@forcodedancing
Merge pull request bnb-chain#4 from flywukong/IO-metrics
2530f64 
add preload metrics
realuncle pushed a commit to realuncle/bsc that referenced this pull request Mar 16, 2022
@pythonberg1997
Merge pull request bnb-chain#4 from Loverush/develop
db60920 
[WIP]Fast Finality: p2p protocol
galaio pushed a commit to galaio/bsc that referenced this pull request Jul 31, 2024
@trianglesphere @mslipper
@protolambda @tynes @maurelian
optimism: historical Bedrock geth rollup changes
c48b8aa 
This commit squashes the op-geth fork history into a more maintainable
diff for rebasing upon upstream geth.

reference-optimistic-geth changes (origins of op-geth in early Bedrock
development stage):
- Deposit TX Type
- Enable deposit tx in EVM/tx pool
- Change deposit nonce to not be the max nonce
- Extend PayloadAttributesV1 with a Transactions field
- Force deposits at the start of each L2 block
- Fix height check
- noTxPool flag, reproduce block in verifier mode without tx pool interference
- Fix RPC json marshalling (ref op-geth PR 4)
- Deposit txs block height check in block body validation (ref op-geth PR 5)
- core: do not try to reinject deposit txs into tx-pool (ref-op-geth PR 6)
- deposit source hash field instead of L2 block height and tx index combination
- Include invalid deposits, rewind state, but always persist mint (bnb-chain#10)
- Provide gas to Call/Create in deposit transactions (bnb-chain#12)
- Add docker builds (ref-op-geth PR 16, 17)
- Don't panic on deposit transaction signature values or chain ID (ref-op-geth PR 18)
- core: Add version to DepositTx (ref-op-geth PR 19)
- Enable Geth build/lint/test in CircleCI (ref-op-geth PR 23)
- core: Include guaranteed gas in the gas pool (ref-op-geth PR 21)
- core: handle base fee, l1 availability fee, tx fee (ref-op-geth PR 27)
- fix: deposit tx hash
- fix l1 fee cache, rpc, tracing and tx pool
- core: remove deposit-tx sub-type (a.k.a. deposit version byte)
- eth/catalyst: allow engine user to reorg own chain
- miner: restore ability to reorg deep as block builder
- params: print Optimism consensus type in banner
- core/types: remove unused protected() method, see upstream PR 23376
- core: do not mutate original balance value in tx pool l1 cost adjustment
- core: subtract deposit gas from pool, so other txs do not use the same gas. And fail tx processing if deposits reach gas limit
- core/types: deposits do not tip, avoid basefee subtraction
- Unmeter the L1 Attributes Transaction
- miner: handle force tx errors as critical, clean up diff
- ci: Switch branch
- eth,miner: return STATUS_INVALID when failing to process forced transactions in request (ref-op-geth PR 40)
- verifier: forward tx to sequencer based on flag
- txpool: add flag to disable tx gossip (ref-op-geth PR 42)
- Add op-geth version in addition to geth version (ref-op-geth PR 43)
- ci: CircleCI improvements (ref-op-geth PR 44)
- Rename to op-geth
- Build latest tag on optimism branch

op-geth changes:
- Expose cache config in simulated backend (bnb-chain#2)
- Add EIP-1559 parameters
- eth/catalyst: update payload id computation (bnb-chain#1)
- make eip1559 configurable (bnb-chain#4)
- post-merge network should not log warnings about missing transition information (bnb-chain#5)
- Make the simulator more configurable (bnb-chain#6)
- fix OPB-6 - IsDepositTx check instead of artificial nonce value check (bnb-chain#7)
- Simulated backend - enable proof of stake consensus type and fix performance issue (bnb-chain#8)
- accounts: simulated backend consensus engine option and immediate tx indexing
- consensus/beacon: recognize all blocks as reached TTD with 0 TTD in chain config
- Add --rollup.historicalhttp CLI flag and fix backend iface
- Flags and interfaces for historical RPC requests (bnb-chain#12)
- Redirect historical RPC requests (bnb-chain#13)
- Use the pre-existing ethereum.NotFound error (bnb-chain#18)
- Add historical endpoint to TraceBlockByNumber and TraceBlockByHash (bnb-chain#19)
- Add historical endpoint to TraceTransaction (bnb-chain#20)
- Add historical endpoint to TraceCall (bnb-chain#21)
- optimism: fee params from info txi, update l1 cost func GPO params read (bnb-chain#15)
- add hardcoded addresses for fee payouts (bnb-chain#23)
- dynamic gas limit via engine API (bnb-chain#22)

Co-authored-by: Matthew Slipper <[email protected]>
Co-authored-by: Joshua Gutow <[email protected]>
Co-authored-by: protolambda <[email protected]>
Co-authored-by: Mark Tyneway <[email protected]>
Co-authored-by: Maurelian <[email protected]>
galaio pushed a commit to galaio/bsc that referenced this pull request Jul 31, 2024
@yutianwu @redhdx
feat: add precompiled contracts for Greenfield link (bnb-chain#7)
cdeca04 
* feat: add precompiled contracts for Greenfield link

* fix bug in lightclient

* fix the comments

* feature: add hardfork logic (bnb-chain#1)

* feature: update hard fork info (bnb-chain#3)

* Fix/fix dockerfile (bnb-chain#4)

* fix: add libc-dev to support greenfield

* feature: update devnet fork block number

* feature: update chain config info (bnb-chain#5)

---------

Co-authored-by: redhdx <[email protected]>
galaio added a commit to galaio/bsc that referenced this pull request Aug 16, 2024
@galaio @sunny2022da
Feat: TxDAG: support TxDAG
3c6f2c2 
rwset: support collect rwset from statedb;
mvstates: support export DAG;
dag: support travel all execution paths;
dag: refactor versioned TxDAG;
dag: support profile parallel execution path;
protocol: support to transfer TxDAG in NewBLock msg;

PR: bnb-chain#4
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yutianwu yutianwu yutianwu approved these changes

@abelliumnt abelliumnt Awaiting requested review from abelliumnt

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@unclezoro @yutianwu