Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: migrate argparse code to typer (#48) #61

Merged
merged 25 commits into from
Oct 31, 2023

Conversation

holtgrewe
Copy link
Contributor

No description provided.

@holtgrewe holtgrewe linked an issue Oct 30, 2023 that may be closed by this pull request
@github-actions
Copy link
Contributor

Please format your code with black: make black.

@codecov
Copy link

codecov bot commented Oct 30, 2023

Codecov Report

Attention: 47 lines in your changes are missing coverage. Please review.

Comparison is base (5822c40) 54.84% compared to head (b1d38f0) 61.84%.
Report is 2 commits behind head on main.

❗ Current head b1d38f0 differs from pull request most recent head ce7791f. Consider uploading reports for the commit ce7791f to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #61      +/-   ##
==========================================
+ Coverage   54.84%   61.84%   +6.99%     
==========================================
  Files          35       19      -16     
  Lines        2323     1444     -879     
==========================================
- Hits         1274      893     -381     
+ Misses       1049      551     -498     
Files Coverage Δ
varfish_cli/api/case.py 28.21% <100.00%> (+7.59%) ⬆️
varfish_cli/api/common.py 100.00% <100.00%> (ø)
varfish_cli/api/models.py 100.00% <100.00%> (+3.08%) ⬆️
varfish_cli/api/project.py 100.00% <100.00%> (+43.75%) ⬆️
varfish_cli/api/varannos.py 100.00% <100.00%> (+76.08%) ⬆️
varfish_cli/cli/cases.py 100.00% <100.00%> (ø)
varfish_cli/cli/projects.py 100.00% <100.00%> (ø)
varfish_cli/cli/varannos.py 100.00% <100.00%> (ø)
varfish_cli/exceptions.py 100.00% <100.00%> (ø)
varfish_cli/__main__.py 75.00% <75.00%> (-25.00%) ⬇️
... and 6 more

... and 2 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@holtgrewe holtgrewe marked this pull request as ready for review October 31, 2023 14:09
@holtgrewe holtgrewe enabled auto-merge (squash) October 31, 2023 14:26
@holtgrewe holtgrewe merged commit d1c86d4 into main Oct 31, 2023
8 checks passed
@holtgrewe holtgrewe deleted the 48-migrate-argparse-code-to-typer branch October 31, 2023 18:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Migrate argparse code to typer
1 participant