Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Newly Cloned Repo fails the Test command #2656

Open
sameer-dudeja opened this issue Jun 20, 2024 · 2 comments
Open

Newly Cloned Repo fails the Test command #2656

sameer-dudeja opened this issue Jun 20, 2024 · 2 comments
Labels
bug Something isn't working devops Changes to the repository structure or project management

Comments

@sameer-dudeja
Copy link
Contributor

I recently cloned the HTMX repo and ran the npm run test command
To my surprise without making any changes it failed for 3 tests, I am new to htmx and might be missing something but in a layman's point of view all tests should pass in the most ideal sense or the test should be modified
I am attaching the screenshot of the failed tests,
image

@kaiji123
Copy link

kaiji123 commented Jul 15, 2024

I have a similar issue when running test , although I just have 2 failed test cases. Below is the screenshot.
image
It seems that issue comes from security.js file from test\core and www\static\test\core with the error being exceeding Timeout of 4000ms.

In this part of code
image

I tried increasing timeout to 12000
this.timeout(12000)

and surprisingly the failed case didn't show up anymore.

image

@Telroshan Telroshan added bug Something isn't working devops Changes to the repository structure or project management labels Jul 16, 2024
@Telroshan
Copy link
Collaborator

Hey, indeed those tests make requests to external URLs and it's unfortunately common to have timeout issues with those...
As it's going to depend on your internet connection for that request, that's probably why increasing the timeout worked for you here.
We need these tests to ensure selfRequestsOnly works as expected, so if you have any idea how to solve that timeout problem (without simply increasing the timeout value in this case), PRs are welcome!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working devops Changes to the repository structure or project management
Projects
None yet
Development

No branches or pull requests

3 participants