Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dependency on streql #9

Closed
jtallieu opened this issue Apr 10, 2014 · 12 comments
Closed

dependency on streql #9

jtallieu opened this issue Apr 10, 2014 · 12 comments

Comments

@jtallieu
Copy link
Contributor

The pip install fails to install streql on python 2.7 on Windows7. It complains that it cannot find vcvarsall.bat. I looked through the API and noticed that streql is only imported, but not used in the code. I was able to use the api on Windows7 by removing that line in connection.py. I don't want to have to install microsoft Visual Anything unless I have to.

@maetl
Copy link
Contributor

maetl commented Apr 10, 2014

If it’s not being used, then we should remove it. Thanks for letting us know.

@tgsergeant
Copy link
Contributor

streql is used in connection.py:213 to provide constant time string comparison for the Single-Click apps load url. (See https://developer.bigcommerce.com/apps/load#signed-payload)

If you're not using Single Click apps, you can safely remove this line yourself.

@jtallieu
Copy link
Contributor Author

Yeah, I missed that in my search. Sorry about that.

On Apr 10, 2014, at 6:54 PM, Tim Sergeant [email protected] wrote:

streqlis used in connection.py:213 to provide constant time string comparison for the Single-Click apps load url. (See https://developer.bigcommerce.com/apps/load#signed-payload)

If you're not using Single Click apps, you can safely remove this line yourself.


Reply to this email directly or view it on GitHub.

@maetl
Copy link
Contributor

maetl commented Apr 11, 2014

Thanks @tgsergeant.

@dineshkrishnareddy
Copy link

did this error solved ??
i am facing the same error now. if u solved this error plz give solution here

@filipeteles
Copy link

Facing the same issue. Tried to remove the lines but Bigcommerce keeps trying to install Streql.

@gabelimon
Copy link
Contributor

@filipeteles, @svcew-dinesh if you are facing this issue remove connection.py:213 and modify setup.py:15. I'll start looking into a permanent fix.

@taleinat
Copy link

See also PeterScott/streql#1

@sabotagebeats
Copy link

@gabelimon i'm still having this issue

@gabelimon
Copy link
Contributor

@bookernath Would you mind taking this over or passing it on to someone who will?

@sabotagebeats
Copy link

@gabelimon @bookernath I was unable to get streql to compile, and pip install bigcommerce was requiring a streql dependency. I ended up removing streql requirement from the setup.py and now I'm able to install bigcommerce. I'm still unsure why I'm unable to compile streql.

@taleinat
Copy link

streql fails to compile on Windows for Python 2.7 because it uses newer C syntax which is not supported by the old version of the MS C++ compiler which needs to be used to build extensions for Python 2.7 on Windows. See PeterScott/streql#1.

streql already has a pure-Python implementation, which is currently only used for PyPy compatibility. I've created PeterScott/streql#5 suggesting to use this as a fallback whenever compiling the C version fails. I also just finished implementing this, see taleinat/streql, and I've created a pull request for the original repo.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

8 participants