Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

settings.layout alignment values are being overridden and have no effect when set on the block #29

Open
Tracked by #32
chrishbite opened this issue Sep 6, 2024 · 0 comments · May be fixed by #39
Open
Tracked by #32
Assignees
Labels
bug Something isn't working

Comments

@chrishbite
Copy link
Collaborator

Expected Behavior

Setting a settings.layout alignment value via the block toolbar should have the corresponding layout effect, reset the containerHeight and containerWidth attributes and remove the WIDTH and HEIGHT settings component.

Actual Behavior

settings.layout alignment values are being overridden by the containerHeight and containerWidth attribute styles and so have no effect on the block when set.

Step-by-step reproduction instructions

  1. Add an Image Comparison block
  2. Add both images
  3. Apply a settings.layout alignment value
  4. See that this has no effect on the block

Screenshots, screen recordings, code snippets

N/A

System Information

  • Browser: Firefox Developer Edition 131.0b2 (aarch64)
  • WordPress version: 6.6.1
  • PHP version: 8.2
@chrishbite chrishbite added the bug Something isn't working label Sep 6, 2024
@PaulREnglish PaulREnglish self-assigned this Oct 7, 2024
@PaulREnglish PaulREnglish linked a pull request Oct 8, 2024 that will close this issue
6 tasks
@chrishbite chrishbite linked a pull request Oct 31, 2024 that will close this issue
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants