Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug]: viewBox stripped out in SVGs #32

Closed
ampersarnie opened this issue May 6, 2022 · 0 comments · Fixed by #33
Closed

[Bug]: viewBox stripped out in SVGs #32

ampersarnie opened this issue May 6, 2022 · 0 comments · Fixed by #33
Assignees
@ampersarnie @g-elwell
Labels
bug Something isn't working
Milestone
v1.0

Comments

@ampersarnie
Copy link
Member

What happened?

SVG's can have viewBox stripped out of them which will cause the appearance of cropping when the SVGs are displayed.

@g-elwell has come across this issue which contains solutions disabling the behaviour of stripping out viewBox from SVGs. We should follow the recommendations in that reported issue to get this resolved in our build tools.

Which environments are you experiencing the issue on?

CLI (macOS, Windows, etc)

Relevant log output

No response
@ampersarnie ampersarnie added the bug Something isn't working label May 6, 2022
@ampersarnie ampersarnie added this to the v1.0 milestone May 6, 2022
@ampersarnie ampersarnie self-assigned this May 6, 2022
@ampersarnie ampersarnie moved this to To do in Build Tools May 6, 2022
@g-elwell g-elwell self-assigned this May 6, 2022
@ampersarnie ampersarnie mentioned this issue May 6, 2022
Merged
Repository owner moved this from To do to Done in Build Tools May 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ampersarnie ampersarnie

@g-elwell g-elwell

Labels
bug Something isn't working
Projects
Build Tools
Archived in project
Milestone
v1.0
Development

Successfully merging a pull request may close this issue.

Disable viewBox removal in SVGO ampersarnie/build-tools
2 participants
@ampersarnie @g-elwell