This repository has been archived by the owner on Mar 13, 2024. It is now read-only.
Move Theme Options to Customizer #34
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a wp.org requirement for themes that declare their own settings. Fallbacks have been added for those who had previously set data using theme options; Customizer settings take priority, but will gracefully degrade. Theme Options related functions have been deprecated and unhooked.
Forcing a redirect to the customiser should handle the user-education side of the change from an admin page to the customiser.
|
To answer the user-education question posited in my original message, I've since updated this PR. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
Since 2015, it's a requirement that themes use the Customizer for theme settings, rather than a custom options page. This PR migrates existing theme options to the Customizer, whilst still allowing pre-defined settings to be used as a fallback.
Old functions which declared the theme options page & settings have been deprecated and unhooked.
One thing it doesn't address is user education. I'd like input on that; should we:
?