Skip to content
This repository has been archived by the owner on Mar 13, 2024. It is now read-only.

[BUG] GA is always enqueued, even without a valid tag #51

Closed
jaymcp opened this issue Jan 7, 2019 · 1 comment
Closed

[BUG] GA is always enqueued, even without a valid tag #51

jaymcp opened this issue Jan 7, 2019 · 1 comment
Labels
bug Something isn't working

Comments

@jaymcp
Copy link
Member

jaymcp commented Jan 7, 2019

Describe the bug
Google Analytics support has a default option fallback of test here.
This means that the GTM script is always output, even if the user has no desire to use GA. Users would have to unhook the call to prevent the script from outputting.

To Reproduce
Steps to reproduce the behaviour:

  1. Install & activate the theme.

Expected behaviour
When no GA code is added to the theme's options, no GTM script should be output.

Screenshots

Platform (please complete the following information):
Platform-independent. Affects all versions of Benenson.

@jaymcp jaymcp added the bug Something isn't working label Jan 7, 2019
@jaymcp jaymcp changed the title [BUG] [BUG] GA is always enqueued, even without a valid tag Jan 8, 2019
@ampersarnie
Copy link
Member

Annoying that ended up in there.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants