Skip to content
This repository has been archived by the owner on Mar 13, 2024. It is now read-only.

[BUG] Embedded videos lack float attribute #160

Closed
jjsanderson opened this issue Jun 20, 2019 · 0 comments · Fixed by #161
Closed

[BUG] Embedded videos lack float attribute #160

jjsanderson opened this issue Jun 20, 2019 · 0 comments · Fixed by #161
Assignees
Labels
bug Something isn't working
Milestone

Comments

@jjsanderson
Copy link

Describe the bug
An embedded video, when set to float right or left alongside the following text block, displays correctly in the editor… but does not float in the resulting public page.

To Reproduce
Steps to reproduce the behaviour:

  1. Create a post
  2. Add a video element, from self-hosted video or an external hosting service.
  3. Select 'align text right/left' from the whatever-that-attached-thing-above-the-box is called.
  4. Publish the page.
  5. View resulting page.

Expected behaviour
Videos should float left/right as images do.

Platform (please complete the following information):

  • OS: OS X 10.14.4
  • Safari and Chrome, current versions.

Additional context
This looks to me like the styles are simply missing the float right/left attributes in the CSS; if I add them, the page renders as expected.

@jjsanderson jjsanderson added the bug Something isn't working label Jun 20, 2019
@jaymcp jaymcp self-assigned this Jun 21, 2019
@jaymcp jaymcp added this to the v1.1.0 milestone Jun 21, 2019
jaymcp added a commit that referenced this issue Jun 21, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants