Code cleanup

Author: popduke

bifromq-dist/bifromq-dist-client/src/main/java/com/baidu/bifromq/dist/client/DistClientBuilder.java

@@ -24,16 +24,18 @@
 import lombok.Setter;
 import lombok.experimental.Accessors;
 
+/**
+ * The builder for building Dist Client.
+ */
 @NoArgsConstructor(access = AccessLevel.PACKAGE)
 @Accessors(fluent = true)
 @Setter
-public final class DistClientBuilder implements IDistClientBuilder {
+public final class DistClientBuilder {
     IRPCServiceTrafficService trafficService;
     EventLoopGroup eventLoopGroup;
     SslContext sslContext;
     int workerThreads = 0;
 
-    @Override
     public IDistClient build() {
         return new DistClient(IRPCClient.newBuilder()
             .bluePrint(RPCBluePrint.INSTANCE)

bifromq-dist/bifromq-dist-client/src/main/java/com/baidu/bifromq/dist/client/IDistClientBuilder.java

@@ -28,12 +28,12 @@
 import lombok.experimental.Accessors;
 
 /**
- * The builder for building dist server.
+ * The builder for building Dist Server.
  */
 @NoArgsConstructor(access = AccessLevel.PACKAGE)
 @Accessors(fluent = true)
 @Setter
-public class DistServerBuilder implements IDistServerBuilder {
+public class DistServerBuilder {
     RPCServerBuilder rpcServerBuilder;
     IBaseKVStoreClient distWorkerClient;
     ISettingProvider settingProvider;
@@ -42,7 +42,6 @@ public class DistServerBuilder implements IDistServerBuilder {
     Set<String> defaultGroupTags = new HashSet<>();
     int workerThreads = 0;
 
-    @Override
     public IDistServer build() {
         Preconditions.checkNotNull(rpcServerBuilder, "RPC Server Builder is null");
         return new DistServer(this);

bifromq-dist/bifromq-dist-server/src/main/java/com/baidu/bifromq/dist/server/DistServerBuilder.java

@@ -43,7 +43,7 @@ private enum Status {
     private final AtomicReference<Status> status = new AtomicReference<>(Status.INIT);
     private final KVStoreBalanceController storeBalanceController;
     private final List<IDistWorkerBalancerFactory> effectiveBalancerFactories = new LinkedList<>();
-    protected final DistWorkerCoProcFactory coProcFactory;
+    private final DistWorkerCoProcFactory coProcFactory;
 
     public DistWorker(DistWorkerBuilder builder) {
         this.clusterId = builder.clusterId;

bifromq-dist/bifromq-dist-server/src/main/java/com/baidu/bifromq/dist/server/IDistServerBuilder.java

@@ -33,12 +33,12 @@
 import lombok.experimental.Accessors;
 
 /**
- * The builder for building dist worker.
+ * The builder for building Dist Worker.
  */
 @NoArgsConstructor(access = AccessLevel.PACKAGE)
 @Accessors(fluent = true)
 @Setter
-public class DistWorkerBuilder implements IDistWorkerBuilder {
+public class DistWorkerBuilder {
     String clusterId = IDistWorker.CLUSTER_NAME;
     RPCServerBuilder rpcServerBuilder;
     IAgentHost agentHost;
@@ -57,7 +57,6 @@ public class DistWorkerBuilder implements IDistWorkerBuilder {
     Duration loadEstimateWindow = Duration.ofSeconds(5);
     Map<String, String> attributes = new HashMap<>();
 
-    @Override
     public IDistWorker build() {
         return new DistWorker(this);
     }

bifromq-dist/bifromq-dist-worker/src/main/java/com/baidu/bifromq/dist/worker/DistWorker.java

@@ -23,10 +23,13 @@
 import lombok.Setter;
 import lombok.experimental.Accessors;
 
+/**
+ * The builder for building Inbox Client.
+ */
 @NoArgsConstructor(access = AccessLevel.PACKAGE)
 @Accessors(fluent = true)
 @Setter
-public final class InboxClientBuilder implements IInboxClientBuilder {
+public final class InboxClientBuilder {
     IRPCServiceTrafficService trafficService;
     EventLoopGroup eventLoopGroup;
     SslContext sslContext;

bifromq-dist/bifromq-dist-worker/src/main/java/com/baidu/bifromq/dist/worker/DistWorkerBuilder.java

@@ -32,12 +32,12 @@
 import lombok.experimental.Accessors;
 
 /**
- * The builder for building inbox server.
+ * The builder for building Inbox Server.
  */
 @NoArgsConstructor(access = AccessLevel.PACKAGE)
 @Accessors(fluent = true)
 @Setter
-public class InboxServerBuilder implements IInboxServerBuilder {
+public class InboxServerBuilder {
     RPCServerBuilder rpcServerBuilder;
     IEventCollector eventCollector;
     IResourceThrottler resourceThrottler;

bifromq-dist/bifromq-dist-worker/src/main/java/com/baidu/bifromq/dist/worker/IDistWorkerBuilder.java

@@ -32,12 +32,12 @@
 import lombok.experimental.Accessors;
 
 /**
- * The builder for building inbox store.
+ * The builder for building Inbox Store.
  */
 @NoArgsConstructor(access = AccessLevel.PACKAGE)
 @Accessors(fluent = true)
 @Setter
-public class InboxStoreBuilder implements IInboxStoreBuilder {
+public class InboxStoreBuilder {
     String clusterId = IInboxStore.CLUSTER_NAME;
     RPCServerBuilder rpcServerBuilder;
     IAgentHost agentHost;
@@ -56,7 +56,6 @@ public class InboxStoreBuilder implements IInboxStoreBuilder {
     Duration gcInterval = Duration.ofMinutes(5);
     Map<String, String> attributes = new HashMap<>();
 
-    @Override
     public IInboxStore build() {
         return new InboxStore(this);
     }

bifromq-inbox/bifromq-inbox-client/src/main/java/com/baidu/bifromq/inbox/client/IInboxClientBuilder.java

@@ -23,10 +23,13 @@
 import lombok.Setter;
 import lombok.experimental.Accessors;
 
+/**
+ * The builder for building Retain Client.
+ */
 @NoArgsConstructor(access = AccessLevel.PACKAGE)
 @Accessors(fluent = true)
 @Setter
-public final class RetainClientBuilder implements IRetainClientBuilder {
+public final class RetainClientBuilder {
     IRPCServiceTrafficService trafficService;
     EventLoopGroup eventLoopGroup;
     SslContext sslContext;

bifromq-inbox/bifromq-inbox-client/src/main/java/com/baidu/bifromq/inbox/client/InboxClientBuilder.java

@@ -28,12 +28,12 @@
 import lombok.experimental.Accessors;
 
 /**
- * The builder for building retain server.
+ * The builder for building Retain Server.
  */
 @NoArgsConstructor(access = AccessLevel.PACKAGE)
 @Accessors(fluent = true)
 @Setter
-public class RetainServerBuilder implements IRetainServerBuilder {
+public class RetainServerBuilder {
     RPCServerBuilder rpcServerBuilder;
     ISettingProvider settingProvider;
     ISubBrokerManager subBrokerManager;
@@ -42,7 +42,6 @@ public class RetainServerBuilder implements IRetainServerBuilder {
     Set<String> defaultGroupTags = new HashSet<>();
     int workerThreads = 0;
 
-    @Override
     public IRetainServer build() {
         Preconditions.checkNotNull(rpcServerBuilder, "RPC Server Builder is null");
         return new RetainServer(this);

bifromq-inbox/bifromq-inbox-server/src/main/java/com/baidu/bifromq/inbox/server/IInboxServerBuilder.java

@@ -34,7 +34,7 @@
 @NoArgsConstructor(access = AccessLevel.PACKAGE)
 @Accessors(fluent = true)
 @Setter
-public class RetainStoreBuilder implements IRetainStoreBuilder {
+public class RetainStoreBuilder {
     String clusterId = IRetainStore.CLUSTER_NAME;
     RPCServerBuilder rpcServerBuilder;
     IAgentHost agentHost;

bifromq-inbox/bifromq-inbox-server/src/main/java/com/baidu/bifromq/inbox/server/InboxServerBuilder.java

@@ -23,16 +23,18 @@
 import lombok.Setter;
 import lombok.experimental.Accessors;
 
+/**
+ * The builder for building Session Dict Client.
+ */
 @NoArgsConstructor(access = AccessLevel.PACKAGE)
 @Accessors(fluent = true)
 @Setter
-public final class SessionDictClientBuilder implements ISessionDictClientBuilder {
+public final class SessionDictClientBuilder {
     private IRPCServiceTrafficService trafficService;
     private EventLoopGroup eventLoopGroup;
     private SslContext sslContext;
     private int workerThreads;
 
-    @Override
     public ISessionDictClient build() {
         return new SessionDictClient(IRPCClient.newBuilder()
             .bluePrint(RPCBluePrint.INSTANCE)