Skip to content

Commit f4ecfd3

Browse files
authored
Use abbreviations for availability topics (#102)
1 parent 91debfd commit f4ecfd3

File tree

2 files changed

+6
-10
lines changed

2 files changed

+6
-10
lines changed

hacs.json

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
22
"name": "Shellies Discovery Gen2",
3-
"homeassistant": "2022.9.0",
3+
"homeassistant": "2022.10.2",
44
"zip_release": true,
55
"filename": "shellies-discovery-gen2.zip"
66
}

python_scripts/shellies_discovery_gen2.py

+5-9
Original file line numberDiff line numberDiff line change
@@ -78,9 +78,9 @@
7878
KEY_MODEL = "mdl"
7979
KEY_NAME = "name"
8080
KEY_PAYLOAD = "pl"
81-
KEY_PAYLOAD_AVAILABLE = "payload_available"
81+
KEY_PAYLOAD_AVAILABLE = "pl_avail"
8282
KEY_PAYLOAD_CLOSE = "pl_cls"
83-
KEY_PAYLOAD_NOT_AVAILABLE = "payload_not_available"
83+
KEY_PAYLOAD_NOT_AVAILABLE = "pl_not_avail"
8484
KEY_PAYLOAD_OFF = "pl_off"
8585
KEY_PAYLOAD_ON = "pl_on"
8686
KEY_PAYLOAD_OPEN = "pl_open"
@@ -103,13 +103,10 @@
103103
KEY_SUBTYPE = "stype"
104104
KEY_SW_VERSION = "sw"
105105
KEY_TOPIC = "t"
106-
KEY_TOPIC_LONG = "topic"
107-
KEY_TOPIC_SUFFIX = "topic_suffix"
108106
KEY_TYPE = "type"
109107
KEY_UNIQUE_ID = "uniq_id"
110108
KEY_UNIT = "unit_of_meas"
111109
KEY_VALUE_TEMPLATE = "val_tpl"
112-
KEY_VALUE_TEMPLATE_LONG = "value_template"
113110

114111
MODEL_PLUS_1 = "shellyplus1"
115112
MODEL_PLUS_1PM = "shellyplus1pm"
@@ -1360,20 +1357,19 @@ def configure_device():
13601357
KEY_CONFIGURATION_URL: device_url,
13611358
}
13621359

1363-
# do not use constants with an abbreviation here
13641360
if wakeup_period > 0:
13651361
availability = None
13661362
expire_after = wakeup_period * 1.2
13671363
else:
13681364
availability = [
13691365
{
1370-
KEY_TOPIC_LONG: TOPIC_ONLINE,
1366+
KEY_TOPIC: TOPIC_ONLINE,
13711367
KEY_PAYLOAD_AVAILABLE: "true",
13721368
KEY_PAYLOAD_NOT_AVAILABLE: "false",
13731369
},
13741370
{
1375-
KEY_TOPIC_LONG: TOPIC_STATUS_RPC,
1376-
KEY_VALUE_TEMPLATE_LONG: TPL_MQTT_CONNECTED,
1371+
KEY_TOPIC: TOPIC_STATUS_RPC,
1372+
KEY_VALUE_TEMPLATE: TPL_MQTT_CONNECTED,
13771373
},
13781374
]
13791375
expire_after = None

0 commit comments

Comments
 (0)