Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug]: RRID of SPM is used for all software in the examples #138

Open
cmaumet opened this issue Aug 27, 2024 · 0 comments · May be fixed by #142
Open

[Bug]: RRID of SPM is used for all software in the examples #138

cmaumet opened this issue Aug 27, 2024 · 0 comments · May be fixed by #142

Comments

@cmaumet
Copy link
Collaborator

cmaumet commented Aug 27, 2024 •
edited by bclenet
Loading

What happened?

In every example file (see e.g. here), the RRID specified for a Software entry is the one of SPM.

Describe the expected ground-truth ?

The RRID should obviously match the piece of software that was actually used.

What soft is concerned

All parsers.
The bug is located in the bids_prov.utils.get_default_graph method as it initializes a graph with SPM's RRID and -to my knowledge- this value is never updated later.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

New @id generation for parsers and other bug corrections bclenet/BEP028_BIDSprov
1 participant
@cmaumet