Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

I can't make some units work #6

Closed
nmaxcom opened this issue May 19, 2020 · 9 comments
Closed

I can't make some units work #6

nmaxcom opened this issue May 19, 2020 · 9 comments

Comments

@nmaxcom
Copy link

nmaxcom commented May 19, 2020

I'm not sure if this is user error; at the very least is a confusing workflow. Since I'm usually having trouble with pounds, I added this to my en_EN-keys.php

'pound' => 'lb',
'pounds' => 'lb',

So, here are some inconsistencies IMO:

This works
image

But this doesn't
image

But it works this way after adding it to en_EN-keys.php
image

This one is about precision that anything else, but still.
image

Thanks for the effort

@biati-digital
Copy link
Owner

That's an error, I'll take a look next weekend

@biati-digital
Copy link
Owner

is this the part that is confusing for you? or there are other things that you consider confusing?

@nmaxcom
Copy link
Author

nmaxcom commented May 19, 2020

Well, to be honest I haven't used it frequently enough to notice more things because I was a bit let down when the lb conversion didn't work. I'm aware it has more things to offer, I'll try to explore more.

The most confusing part is having one way conversions, e.g.: kg to lb, but not lb to kg.

@biati-digital
Copy link
Owner

Ahh ok, it does not have one way conversions, what you found it's simply an error, for example you can try

1 kg to oz
1 oz to kg

or

1 usd in yen
1 yen in usd

etc.

This update was a complete rewrite so there are probably some bugs. If you find another bug please let me know.

@biati-digital
Copy link
Owner

There's a new update (2.0.2) that fixes the errors you mention, please try it and let me know if it's working for you.

@nmaxcom
Copy link
Author

nmaxcom commented May 25, 2020

Weird. I try to update using "Calculate check for updates" and I get this:
image

But when I go to Alfred Workflows it shows me I'm using the 2.0.1 version.

@biati-digital
Copy link
Owner

Sorry, I forgot to update the version of the GitHub plist file, please try again "Calculate check for updates"

@nmaxcom
Copy link
Author

nmaxcom commented May 26, 2020

It works great now. Both the conversion from lb and the precision are working as expected.

I see in your commit you added pound and pounds, that's great. Would you mind adding lbs as a lb synonym?
Thanks!

@biati-digital
Copy link
Owner

Great, I'll add it in the next update ☺️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants