Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Separate builds should truly be separate #735

Open
jeaye opened this issue Apr 26, 2019 · 0 comments
Open

Separate builds should truly be separate #735

jeaye opened this issue Apr 26, 2019 · 0 comments

Comments

@jeaye
Copy link
Contributor

jeaye commented Apr 26, 2019

Hey @bhauman. You had mentioned here that Figwheel is following cljsbuild, but I don't think that's the case anymore. Nowadays, it seems cljsbuild handles this in stride, but Figwheel requires :load-all-builds false to be specified. Here's a minimal test case showing the behavior of both: https://github.com/jeaye/figwheel-build-issue

This took a handful of hours to realize, given that I was in a large project with several build and profile combinations and had just reorganized a lot of things. Turns out, it was just Figwheel needing a flag!

Will you please make this option default? I don't see how this would negatively affect anyone and it would follow what cljsbuild is doing.

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant