Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Variable width #6

Open
ahopkins opened this issue Dec 4, 2019 · 2 comments
Open

Variable width #6

ahopkins opened this issue Dec 4, 2019 · 2 comments
Labels
enhancement New feature or request

Comments

@ahopkins
Copy link

ahopkins commented Dec 4, 2019

Nice work on this package. Exactly what I needed.

One thing that would be nice would be the ability to control the width. 40vw can be pretty big in some cases, and in other it would be nice to have a fixed size. Of course it can be done with a wrapper component and overriding the CSS, but it can get messy.
@antony
Copy link
Member

antony commented Dec 6, 2019

@ahopkins I agree. It could be passed as an option to the notification (I'd also consider wrapping the display duration up in this options object as well). I'd be happy to accept a PR on this if you fancy having a go.

@fujeffrey1
Copy link

I was having the same issue and gave it a shot. Heres the PR: #7

@antony antony added the enhancement New feature or request label Mar 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@ahopkins @antony @fujeffrey1