Add consent agreement status to events #67
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the
agreedstatus (trueorfalse) to both the component and window consent events. It enables to check whether consent was given or rejected. If a user changes their mind and updates their settings after their initial decision, it’s now possible to act accordingly (and disable analytics tools without reloading the page for example).It implies a breaking change, since the events will now be fired agreed to or not. Existing code needs to be updated by adding a check for
event.detail.agreed. Using the same event as before is more elegant than adding a completely new event with a different naming logic in my opinion (which would be necessary since the original event simply uses its consent type as name).Closes #63