Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Latest version of joe breaks docpad plugin tests #19

Closed
SteveMcArthur opened this issue Jun 26, 2016 · 3 comments
Closed

Latest version of joe breaks docpad plugin tests #19

SteveMcArthur opened this issue Jun 26, 2016 · 3 comments
Assignees
Labels
bug Broken or unexpected

Comments

@SteveMcArthur
Copy link

SteveMcArthur commented Jun 26, 2016

To get docpad plugin tests to work I need to downgrade to version 1.6 of joe and 2.4.3 of event-emitter-grouped. See issue raised over at docpad: issue 104

@mikeumus mikeumus added the bug Broken or unexpected label Jun 26, 2016
@balupton
Copy link
Member

Probably caused by #18 will look into this

balupton added a commit that referenced this issue Nov 4, 2016
- The before and after hooks are now stable and documented
	- `before` and `after` listers fire with the context as the item they
are bound to, receiving no arguments besides the optional completion
callback
  - `task.before`, `task.after`, `suite.before`, `suite.after`
listeners fire with the context as the suite they are bound to,
receiving the first argument as the item for the hook, as well as the
optional completion callback
- Suite initialiser methods now get descriptive names instead of no name
- If a suite or test encounter an error, the `finish[Test|Suite]`
reporting now always occurs regardless of `reporting` preference
- The global suite now has a name of `global joe suite`, it is up to
the reporters to filter this out
- Reporter can now be specified via the `JOE_REPORTER` environment
variable
- Reporter must now be specified, no longer defaults to
`joe-reporter-console`
- `--joe-reporter` and `JOE_REPORTER` can now point to paths to load
- `setReporter` now expects to receive a reporter instance
- Exit reporting now contains the reason for the exit as the second
argument
- `getItemName` has now been removed, it should be handled by the
reporters instead
- `uncaughtException` method has been removed, it doesn't make sense
being an API call
- Simplified cross environment (browser, windows, etc) handling
- Exiting should now be more reliable across different node versions
and browser environments
  - browsers will now have exit reporting by waiting for the global
suite to destroy
  - on node
    - joe will now listen to `beforeExit` so exits can perform more
reliably
    - joe will no longer bother with `SIGINT` on windows as
`beforeExit` should now accomplish that
    - joe will no longer listen to the global suites completion event
to exit, now it just listens to the `beforeExit`, `exit`, and
`uncaughtException` events
      - this is groundwork to solving [issue
#19](#19) (a regression since v1.8.0)
- Early node version support added once again without the need of a
polyfill
- Moved examples out from this repository into the new [`joe-examples`
repository](https://github.com/bevry/joe-examples)
- Testing infrastructure now tests the most common reporters against
the most common examples
- Updated base files
Aglezabad added a commit to UnivUnix/docpad-plugin-api that referenced this issue Aug 2, 2017
Aglezabad added a commit to UnivUnix/docpad-plugin-api that referenced this issue Aug 2, 2017
* Working on #11

* Working on #11

* Trying to get Travis build pass (#11)

* Downgrading joe module due to bevry/kava#19

* Rechecking #11
@balupton
Copy link
Member

So looking at docpad/docpad-plugin-eco@834fccc

It seems I fixed this in April 2017. Also seems I automated the fix. Seems the fix is merely running https://github.com/bevry/based on the affected plugins.

@balupton
Copy link
Member

@Aglezabad ^^

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Broken or unexpected
Development

No branches or pull requests

3 participants