Private state update metadata and migration (release 1.4)#402
Merged
lucassaldanha merged 28 commits intoFeb 17, 2020
Conversation
Signed-off-by: Lucas Saldanha <lucas.saldanha@consensys.net>
Signed-off-by: Lucas Saldanha <lucas.saldanha@consensys.net>
Signed-off-by: Lucas Saldanha <lucas.saldanha@consensys.net>
Signed-off-by: Lucas Saldanha <lucas.saldanha@consensys.net>
Signed-off-by: Lucas Saldanha <lucas.saldanha@consensys.net>
Signed-off-by: Lucas Saldanha <lucas.saldanha@consensys.net>
Signed-off-by: Lucas Saldanha <lucas.saldanha@consensys.net>
Signed-off-by: Lucas Saldanha <lucas.saldanha@consensys.net>
Signed-off-by: Lucas Saldanha <lucas.saldanha@consensys.net>
Signed-off-by: Lucas Saldanha <lucas.saldanha@consensys.net>
Signed-off-by: Lucas Saldanha <lucas.saldanha@consensys.net>
Signed-off-by: Lucas Saldanha <lucas.saldanha@consensys.net>
This reverts commit 118c7e5 Signed-off-by: Lucas Saldanha <lucas.saldanha@consensys.net>
Signed-off-by: Lucas Saldanha <lucas.saldanha@consensys.net>
Signed-off-by: Lucas Saldanha <lucas.saldanha@consensys.net>
Signed-off-by: Lucas Saldanha <lucas.saldanha@consensys.net>
Signed-off-by: Lucas Saldanha <lucas.saldanha@consensys.net>
Signed-off-by: Lucas Saldanha <lucas.saldanha@consensys.net>
Signed-off-by: Lucas Saldanha <lucas.saldanha@consensys.net>
lucassaldanha
changed the title
Signed-off-by: Lucas Saldanha <lucas.saldanha@consensys.net>
Signed-off-by: Lucas Saldanha <lucas.saldanha@consensys.net>
Signed-off-by: Lucas Saldanha <lucas.saldanha@consensys.net>
pinges
reviewed
Feb 14, 2020
| .orElseThrow(PrivateStorageMigrationException::new); | ||
|
|
||
| final List<Transaction> transactionsToProcess = | ||
| block.getBody().getTransactions().subList(0, lastPmtIndex + 1); |
Contributor
There was a problem hiding this comment.
are you sure about the index+1? I would have thought that index is the actual index to use for the pmt ...
Not that it really matters, we would only execute one transaction that we don't have to execute ...
Contributor
Author
There was a problem hiding this comment.
The sublist params are (inclusive, exclusive). We have a unit test checking the logic :)
| } | ||
|
|
||
| if (isResultingPrivateStateRootAtHeadValid()) { | ||
| privateStateStorage.updater().putDatabaseVersion(SCHEMA_VERSION_1_4_x).commit(); |
Contributor
There was a problem hiding this comment.
I'm not sure about the constant name for the schema version. This is going to be the version from 1.4 onwards, but maybe we are going to change the schema within the 1.4 versions again ...
Maybe introduce an Enum for the version number that could be used to match the version number to a String that could be used to have meaningful error messages ...
Contributor
Author
There was a problem hiding this comment.
I'll rename the constants to SCHEMA_VERSION_1_0_0 and SCHEMA_VERSION_1_4_0 to make it clearer that they are specific to this release. Let's save the enum idea for when we need to change the version again! :)
Signed-off-by: Lucas Saldanha <lucas.saldanha@consensys.net>
MadelineMurray
approved these changes
Feb 17, 2020
lucassaldanha
added a commit
to lucassaldanha/besu
that referenced
this pull request
Feb 17, 2020
(backport from release-1.4) Private state update metadata and migration Signed-off-by: Lucas Saldanha <lucas.saldanha@consensys.net>
lucassaldanha
added a commit
to lucassaldanha/besu
that referenced
this pull request
Feb 17, 2020
(backport from release-1.4) Private state update metadata and migration Signed-off-by: Lucas Saldanha <lucas.saldanha@consensys.net>
lucassaldanha
added a commit
to lucassaldanha/besu
that referenced
this pull request
Feb 17, 2020
(backport from release-1.4) Private state update metadata and migration Signed-off-by: Lucas Saldanha <lucas.saldanha@consensys.net>
siladu
pushed a commit
to siladu/besu
that referenced
this pull request
Oct 28, 2024
* Merge getPayloadV3 and getBlobsBundleV1 * Update src/engine/experimental/blob-extension.md Co-authored-by: g11tech <develop@g11tech.io> * kzgs -> commitments * Update src/engine/experimental/blob-extension.md --------- Co-authored-by: g11tech <develop@g11tech.io>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR description
• Updated the private state storage with new data structures that aren't backwards compatible.
• Added PrivateStateRootResolver that handles public chain forks and their impact on the private state
• Created migration logic that will process previous private txs and re-create the data in the update 1.4.x format.
• Migration is based on the schema version, defined in the
PrivateStateStorage• Added flag that user needs to "opt-in" to migrate the data
• Remove restriction for "latest" block from
priv_call