Skip to content

Plugin error stack traces #369

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
shemnon merged 2 commits into from
Feb 7, 2020
Merged

Plugin error stack traces #369

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
10789ab
Plugin error stack traces
shemnon Feb 6, 2020
eea36b9
just the name, not the tostring
shemnon Feb 6, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 7 additions & 5 deletions besu/src/main/java/org/hyperledger/besu/services/BesuPluginContextImpl.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -96,8 +96,9 @@ public void registerPlugins(final Path pluginsDir) {
addPluginVersion(plugin);
} catch (final Exception e) {
LOG.error(
"Error registering plugin of type {}, start and stop will not be called. \n{}",
plugin.getClass(),
"Error registering plugin of type "
+ plugin.getClass().getName()
+ ", start and stop will not be called.",
e);
continue;
}
Expand Down Expand Up @@ -140,8 +141,9 @@ public void startPlugins() {
LOG.debug("Started plugin of type {}.", plugin.getClass().getName());
} catch (final Exception e) {
LOG.error(
"Error starting plugin of type {}, stop will not be called. \n{}",
plugin.getClass(),
"Error starting plugin of type "
+ plugin.getClass().getName()
+ ", stop will not be called.",
e);
pluginsIterator.remove();
}
Expand All @@ -164,7 +166,7 @@ public void stopPlugins() {
plugin.stop();
LOG.debug("Stopped plugin of type {}.", plugin.getClass().getName());
} catch (final Exception e) {
LOG.error("Error stopping plugin of type {}. \n{}", plugin.getClass(), e);
LOG.error("Error stopping plugin of type " + plugin.getClass().getName(), e);
}
}

Expand Down