Skip to content

Editorial mdlint and vale updates to HowTo/Interact/APIs directory#215

Merged
grantnoble merged 42 commits into
besu-eth:masterfrom
grantnoble:grantnoble-howto-interact-apis-mdlint-vale
Mar 1, 2020
Merged

Editorial mdlint and vale updates to HowTo/Interact/APIs directory#215
grantnoble merged 42 commits into
besu-eth:masterfrom
grantnoble:grantnoble-howto-interact-apis-mdlint-vale

Conversation

@grantnoble
Copy link
Copy Markdown

@grantnoble grantnoble commented Feb 27, 2020

mdlint and vale updates including line length <=100, EOL spaces removed, blank lines, passive voice to active voice.

@grantnoble grantnoble self-assigned this Feb 27, 2020
EdJoJob and others added 26 commits February 27, 2020 21:03
@EdJoJob
Windows is now supported in the quickstart (#143)
22d8e71 
Signed-off-by: Edward Evans <edward.joshua.evans@gmail.com>
Signed-off-by: grantnoble <grant.noble@consensys.net>
@joshuafernandes
quickstart updates all round (#141)
499f962 
* updating the hdwallet provider package

* updating json rpc port in the quickstart docs

* pr fixes

Signed-off-by: Joshua Fernandes <joshua.fernandes@consensys.net>
Signed-off-by: Edward Evans <edward.joshua.evans@gmail.com>
Signed-off-by: grantnoble <grant.noble@consensys.net>
@MadelineMurray @MadelineAu
Fixed typo (#150)
3712369 
* Added default data location

Signed-off-by: Madeline Murray <madeline.taylor@gmail.com>

* Fixed typo

Signed-off-by: Madeline Murray <madeline.taylor@gmail.com>

Co-authored-by: MadelineAu <40311741+MadelineAu@users.noreply.github.com>
Signed-off-by: grantnoble <grant.noble@consensys.net>
@bgravenorst @MadelineMurray
Add multi-tenancy information. (#131)
2715ab6 
* Add multi-tenancy information.

Signed-off-by: Byron Gravenorst <byron.gravenorst@consensys.net>

* Minor updates.

Signed-off-by: Byron Gravenorst <byron.gravenorst@consensys.net>

* Implement reviewer feedback.

Signed-off-by: Byron Gravenorst <byron.gravenorst@consensys.net>

* Update diagram.

Signed-off-by: Byron Gravenorst <byron.gravenorst@consensys.net>

* Address reviewer feedback.

Signed-off-by: Byron Gravenorst <byron.gravenorst@consensys.net>

Co-authored-by: MadelineMurray <43356962+MadelineMurray@users.noreply.github.com>
Signed-off-by: grantnoble <grant.noble@consensys.net>
@EdJoJob
Apply renames for the quickstart repo (#152)
c826849 
* Remove instructions for broken Azure Quickstart
* Rename Quickstart tutorials to Example Tutorials
* Rename references to the repository to be sample-networks

Signed-off-by: Edward Evans <edward.joshua.evans@gmail.com>
Signed-off-by: grantnoble <grant.noble@consensys.net>
@MadelineMurray @MadelineAu
Added content on protocol upgrades (#132)
0379da7 
* Added default data location

Signed-off-by: Madeline Murray <madeline.taylor@gmail.com>

* added protocol upgrades content

Signed-off-by: Madeline Murray <madeline.taylor@gmail.com>

* rework

Signed-off-by: Madeline Murray <madeline.taylor@gmail.com>

Co-authored-by: MadelineAu <40311741+MadelineAu@users.noreply.github.com>
Signed-off-by: grantnoble <grant.noble@consensys.net>
@MadelineMurray @MadelineAu
Fixed Ansible link and renamed topic (#168)
a6be934 
* Added default data location

Signed-off-by: Madeline Murray <madeline.taylor@gmail.com>

* added protocol upgrades content

Signed-off-by: Madeline Murray <madeline.taylor@gmail.com>

* rework

Signed-off-by: Madeline Murray <madeline.taylor@gmail.com>

* Updated link and changed topic name

Signed-off-by: Madeline Murray <madeline.taylor@gmail.com>

Co-authored-by: MadelineAu <40311741+MadelineAu@users.noreply.github.com>
Signed-off-by: grantnoble <grant.noble@consensys.net>
@wslyvh
permissioning (#170)
cf2cd97 
Signed-off-by: wslyvh <wslyvh@users.noreply.github.com>
Signed-off-by: grantnoble <grant.noble@consensys.net>
Vale and mdlint editorial updates - DCO.md (#162)
413c913 
Signed-off-by: grantnoble <grant.noble@consensys.net>
@NicolasMassart
updated CI and customised checks (#165)
d4412d9 
- updated CI config to remove useless DIND -> now directly using the target
image with the correct soft installed as it was otherwise not possible to run
the jobs locally with Circle CI CLI.
- Updated and customised Vale config rules
- Updated en customised markdownlint config and rules
- moved config files to CI folder
- added scripts to run CI jobs locally with Circle CI CLI.

Signed-off-by: Nicolas MASSART <nicolas.massart@consensys.net>
Signed-off-by: grantnoble <grant.noble@consensys.net>
@MadelineMurray
Added new NAT options (#179)
3c2350d 
Signed-off-by: Madeline Murray <madeline.taylor@gmail.com>
Signed-off-by: grantnoble <grant.noble@consensys.net>
Editorial mdlint vale updates for Concepts/Transactions directory (#185)
0aac597 
Signed-off-by: grantnoble <grant.noble@consensys.net>
Signed-off-by: grantnoble <grant.noble@consensys.net>
Editorial mklint and vale updates in Concepts/Permissioning dir (#181)
36219ff 
Signed-off-by: grantnoble <grant.noble@consensys.net>
Signed-off-by: grantnoble <grant.noble@consensys.net>
mdlint and vale editorial updates in Concepts/Consensus-Protocols dir…
7cc3993 
…ectory (#180)

Signed-off-by: Madeline Murray <madeline.taylor@gmail.com>
Signed-off-by: grantnoble <grant.noble@consensys.net>
mdlint and vale editorial edits in the Concepts directory (#177)
85316a3 
Signed-off-by: Madeline Murray <madeline.taylor@gmail.com>
Signed-off-by: grantnoble <grant.noble@consensys.net>
vale and mklint editorial updates - CONTRIBUTING.md (#163)
b158642 
Signed-off-by: Madeline Murray <madeline.taylor@gmail.com>
Signed-off-by: grantnoble <grant.noble@consensys.net>
mdlint and vale editorial updates - index.md (#169)
f69ea29 
Signed-off-by: Madeline Murray <madeline.taylor@gmail.com>
Signed-off-by: grantnoble <grant.noble@consensys.net>
@MadelineMurray
Added plugins_reloadPluginConfig (#184)
f75f3c6 
Signed-off-by: Madeline Murray <madeline.taylor@gmail.com>

Signed-off-by: grantnoble <grant.noble@consensys.net>
@bgravenorst
[BESU-163] Add inbound and outbound TLS information. (#124)
c349917 
* BESU-163: Add inbound TLS information.

Signed-off-by: Byron Gravenorst <byron.gravenorst@consensys.net>

* Implement reviewer feedback..

Signed-off-by: Byron Gravenorst <byron.gravenorst@consensys.net>

* Add privacy CLI options.

Signed-off-by: Byron Gravenorst <byron.gravenorst@consensys.net>

* Add privact CLI options.

Signed-off-by: Byron Gravenorst <byron.gravenorst@consensys.net>

* Added privacy CLI commands.

Signed-off-by: Byron Gravenorst <byron.gravenorst@consensys.net>

* Add Privacy CLI options.

Signed-off-by: Byron Gravenorst <byron.gravenorst@consensys.net>

* Implement reviewer feedback.

Signed-off-by: Byron Gravenorst <byron.gravenorst@consensys.net>

* Implement reviewer feedback.

Signed-off-by: Byron Gravenorst <byron.gravenorst@consensys.net>
Signed-off-by: grantnoble <grant.noble@consensys.net>
@bgravenorst
Add multi-tenancy whitelist info. (#193)
1ab4552 
* Add multi-tenancy whitelist info.

Signed-off-by: Byron Gravenorst <byron.gravenorst@consensys.net>

* Minor change to kick off Circle CI build.

Signed-off-by: Byron Gravenorst <byron.gravenorst@consensys.net>
Signed-off-by: grantnoble <grant.noble@consensys.net>
@NicolasMassart
add redirect plugin and initial configuration from RTD redirects (#172)
a278fce 
* add redirect plugin and initial configuration from RTD redirects
* added redirect for uPnP

Signed-off-by: Nicolas MASSART <nicolas.massart@consensys.net>
Signed-off-by: grantnoble <grant.noble@consensys.net>
Editorial mdlint and vale updates in the Concepts/Privacy dir (#183)
057be89 
Signed-off-by: grantnoble <grant.noble@consensys.net>
Signed-off-by: grantnoble <grant.noble@consensys.net>
Editorial mdlink and vale updates for HowTo/Configure directory (#187)
af2b184 
Signed-off-by: Madeline Murray <madeline.taylor@gmail.com>
Signed-off-by: grantnoble <grant.noble@consensys.net>
Editorial mdlint and vale updates to Howto/Backup directory (#186)
c72fb6a 
Signed-off-by: Madeline Murray <madeline.taylor@gmail.com>
Signed-off-by: grantnoble <grant.noble@consensys.net>
@NicolasMassart
add an info pass for md linting (#205)
3b74005 
adding an info pass that's not breaking the build
the breaking checks are on another run in the same job
two artifacts are now produced
line length check is now only in the info pass

Signed-off-by: Nicolas MASSART <nicolas.massart@consensys.net>
Signed-off-by: grantnoble <grant.noble@consensys.net>
@NicolasMassart
add postman collection locally and fix the postman button style (#174)
0ade2c8 
* add postman collection locally and fix the postman button style

fixed the button that is an image and was taken in account for zoom feature.
Zoom only works on non link images now.

Signed-off-by: Nicolas MASSART <nicolas.massart@consensys.net>

* ignore the link to postman as include prevents the check

Ignoring an internal file is ok as soon as we target it in a detailed
way to prevent the pattern to accidentally ignore another file.

Signed-off-by: Nicolas MASSART <nicolas.massart@consensys.net>

* remove the reference to "our site" as requested by @MadelineMurray

Signed-off-by: Nicolas MASSART <nicolas.massart@consensys.net>
Signed-off-by: grantnoble <grant.noble@consensys.net>
NicolasMassart and others added 15 commits February 27, 2020 21:03
@NicolasMassart
fix code blocks in doc by updating mkdocs and dependencies (#158)
4b9307f 
* update mkdocs and dependencies to fix code blocks

anyway it was a necessary update

Signed-off-by: Nicolas MASSART <nicolas.massart@consensys.net>

* trying material 4.6.3

Signed-off-by: Nicolas MASSART <nicolas.massart@consensys.net>
Signed-off-by: grantnoble <grant.noble@consensys.net>
@bgravenorst @NicolasMassart
Add links to TLS content. (#191)
56c6c22 
Signed-off-by: Byron Gravenorst <byron.gravenorst@consensys.net>

Co-authored-by: Nicolas MASSART <NicolasMassart@users.noreply.github.com>
Signed-off-by: grantnoble <grant.noble@consensys.net>
@bgravenorst @NicolasMassart
Add TLS diagram. (#194)
394759c 
Signed-off-by: Byron Gravenorst <byron.gravenorst@consensys.net>

Co-authored-by: Nicolas MASSART <NicolasMassart@users.noreply.github.com>
Signed-off-by: grantnoble <grant.noble@consensys.net>
@bgravenorst
Add Besu Plugin information (#142)
e22ad07 
* Add Besu Plugin information.

Signed-off-by: Byron Gravenorst <byron.gravenorst@consensys.net>

* Added webinar link.

Signed-off-by: Byron Gravenorst <byron.gravenorst@consensys.net>

* Address Tech Review comments.

Signed-off-by: Byron Gravenorst <byron.gravenorst@consensys.net>

* Address review feedback.

Signed-off-by: Byron Gravenorst <byron.gravenorst@consensys.net>

* Add javadoc links.

Signed-off-by: Byron Gravenorst <byron.gravenorst@consensys.net>
Signed-off-by: grantnoble <grant.noble@consensys.net>
@MadelineMurray
Added reorg compatible privacy (#192)
e08955f 
Signed-off-by: Madeline Murray <madeline.taylor@gmail.com>
Signed-off-by: grantnoble <grant.noble@consensys.net>
add priv_call API Method (#144)
2f66e17 
Signed-off-by: grantnoble <grant.noble@consensys.net>
Signed-off-by: grantnoble <grant.noble@consensys.net>
@MadelineMurray
Added tracing API (#182)
3e1fc00 
Signed-off-by: Madeline Murray <madeline.taylor@gmail.com>
Signed-off-by: grantnoble <grant.noble@consensys.net>
@NicolasMassart
Add Grant as a maintainer (#199)
644ce39 
Signed-off-by: Nicolas MASSART <nicolas.massart@consensys.net>
Signed-off-by: grantnoble <grant.noble@consensys.net>
@MadelineMurray
Added auto log bloom caching option (#210)
364f7d3 
Signed-off-by: Madeline Murray <madeline.taylor@gmail.com>
Signed-off-by: grantnoble <grant.noble@consensys.net>
@MadelineMurray
Added caution about pruning bug (#212)
acbcd8f 
Signed-off-by: Madeline Murray <madeline.taylor@gmail.com>
Signed-off-by: grantnoble <grant.noble@consensys.net>
@MadelineMurray
Updated per feedback (#213)
2577e92 
Signed-off-by: Madeline Murray <madeline.taylor@gmail.com>
Signed-off-by: grantnoble <grant.noble@consensys.net>
Editorial mdlint and vale updates to HowTo/Interact/APIs dir
8974f05 
mdlint and vale updates including line length <=100, EOL spaces removed, blank lines, passive voice to active voice.

Signed-off-by: grantnoble <grant.noble@consensys.net>
More changes, espec to Using-JSON-RPC-API.md
0d3dc85 
Signed-off-by: grantnoble <grant.noble@consensys.net>
A few minor changes
ec3514f 
Signed-off-by: grantnoble <grant.noble@consensys.net>
Merge branch 'master' into grantnoble-howto-interact-apis-mdlint-vale
6caadb4
NicolasMassart
NicolasMassart approved these changes Feb 27, 2020
View reviewed changes
Copy link
Copy Markdown
Contributor

@NicolasMassart NicolasMassart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@grantnoble grantnoble merged commit 6aa5669 into besu-eth:master Mar 1, 2020
@grantnoble grantnoble deleted the grantnoble-howto-interact-apis-mdlint-vale branch March 2, 2020 01:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@MadelineMurray MadelineMurray Awaiting requested review from MadelineMurray

@bgravenorst bgravenorst Awaiting requested review from bgravenorst

1 more reviewer

@NicolasMassart NicolasMassart NicolasMassart approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@grantnoble grantnoble

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@grantnoble @NicolasMassart @EdJoJob @joshuafernandes @MadelineMurray @bgravenorst @wslyvh