Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: Support horizontal collapse #444

Closed
demetrius-mp opened this issue Feb 18, 2022 · 5 comments · Fixed by #445
Closed

Feat: Support horizontal collapse #444

demetrius-mp opened this issue Feb 18, 2022 · 5 comments · Fixed by #445

Comments

@demetrius-mp
Copy link
Contributor

i was trying to rebuild this sidebar using sveltestrap, but the default animations works only vertically, which feels weird for this use case. I tried adding .collapse-horizontal to the Collapse component, but it happened to be even weirder.

@demetrius-mp
Copy link
Contributor Author

or maybe provide a workaround for the moment, cause i really dont see other way to "fix" this but to use bootstrap javascript, which is not desirable

@bestguy
Copy link
Owner

bestguy commented Feb 18, 2022

Thanks, yeah I attempted adding support and was a little confused on how this was supposed to work. Happy to take a look again and either PR or add my notes here if someone could pick it up.

@bestguy
Copy link
Owner

bestguy commented Feb 18, 2022

I think this is straightforward if you'd like to review @demetrius-mp : https://github.com/bestguy/sveltestrap/pull/445/files

@demetrius-mp
Copy link
Contributor Author

it works just great! you can close the issue if you want.

@bestguy bestguy reopened this Feb 18, 2022
@bestguy
Copy link
Owner

bestguy commented Feb 18, 2022

Released in v5.9.0, thanks for the heads up.

@bestguy bestguy closed this as completed Feb 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants